Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars not filled on iPhone #48

Open
zacBkh opened this issue Jun 14, 2023 · 4 comments
Open

Stars not filled on iPhone #48

zacBkh opened this issue Jun 14, 2023 · 4 comments

Comments

@zacBkh
Copy link

zacBkh commented Jun 14, 2023

Hello,
Thanks a lot for the amazing library.

I have noticed on iPhone only the stars are not filled in yellow in static mode (readOnly) when displaying the rate.
Please see the screenshot attached.

It works perfectly on Android phone, the issue appears only on iphone.
Any idea what's happening?

image

Thanks!

@vandercloak
Copy link

I am having the same issue with Safari Version 16.5.1 (18615.2.9.11.7). It was working fine on 15.5, but since upgrading it is broken. Works great on chrome.

I believe it has to do with issue/support for display: -webkit-inline-box. I do not yet have a solution, but will post back if I find one.

@vandercloak
Copy link

I got it working... But its VERY hacky... but in the hopes it saves someone else some time, here is what worked for me:

<Rating
  emptyStyle={{ display: "flex" }}
  SVGstyle={{ display: "inline-block", marginBottom: 10 }}
  style={{ marginBottom: -10 }}
  ...
/>

The stars were positioned wrong for some reason and the two margin styles resolved it for me so they yellow stars showed up correctly.

1 similar comment
@vandercloak
Copy link

I got it working... But its VERY hacky... but in the hopes it saves someone else some time, here is what worked for me:

<Rating
  emptyStyle={{ display: "flex" }}
  SVGstyle={{ display: "inline-block", marginBottom: 10 }}
  style={{ marginBottom: -10 }}
  ...
/>

The stars were positioned wrong for some reason and the two margin styles resolved it for me so they yellow stars showed up correctly.

@Phongtesla
Copy link

Spending an hour playing with it, i figured out this
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants