-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[warning ] Ignoring property 'compatibilities', 'taskDefinitionArn', 'requiresAttributes', 'revision', 'status' in the task definition file #176
Comments
@nodesocket looks like your task definition contains a number of properties that are invalid |
@allisaurus I think most workflows include downloading the existing task definition and then updating the image tag. So the values you mentioned will be there. This way we don't have to keep the task definition in the repo |
@kyler-hyuna that's a good point. I think this action was originally envisioned for use with a task definition file in the repo, but pulling one that exists elsewhere and modifying it is a common pattern. I don't have any immediate suggestions re: how to make the warnings less annoying, but since it's not a deployment blocker how about we mark this as a feature request for now so we don't lose track of it? |
Yep sounds good. The warnings are correct in that the fields aren't needed, however, maybe we can do either 2 things:
Either one is fine! |
Is there anything that speaks against simply not setting those properties? |
@allisaurus this is breaking the build now. Pls help. |
@siddhant-mohan when did you see this? I did a build today, with no issues |
It started failing today, it says:
|
hmm sounds like ECS itself may now be failing on the presence of these values. We will follow up on this and post an update. |
@siddhant-mohan @a-ruban-craftsoft which AWS regions are you deploying to, for context? |
@allisaurus eu-west-1 |
@allisaurus I guess it is might be related to sdk been updated to v2.829.0 but I may be wrong |
ap-south-1 @allisaurus |
@siddhant-mohan @a-ruban-craftsoft it looks like the failure is actually coming from the amazon-ecs-deploy-task-definition action, which is failing on the presence of the new fields. We are actively working on a fix and will post updates here: #164 |
@allisaurus thanks for sorting this out |
hmm... is this still in the air? Ignoring property 'compatibilities' in the task definition file. This property is returned by the Amazon ECS DescribeTaskDefinition API and may be shown in the ECS console, but it is not a valid field when registering a new task definition. This field can be safely removed from your task definition file.
Ignoring property 'taskDefinitionArn' in the task definition file. This property is returned by the Amazon ECS DescribeTaskDefinition API and may be shown in the ECS console, but it is not a valid field when registering a new task definition. This field can be safely removed from your task definition file.
Ignoring property 'requiresAttributes' in the task definition file. This property is returned by the Amazon ECS DescribeTaskDefinition API and may be shown in the ECS console, but it is not a valid field when registering a new task definition. This field can be safely removed from your task definition file.
Ignoring property 'revision' in the task definition file. This property is returned by the Amazon ECS DescribeTaskDefinition API and may be shown in the ECS console, but it is not a valid field when registering a new task definition. This field can be safely removed from your task definition file.
Ignoring property 'status' in the task definition file. This property is returned by the Amazon ECS DescribeTaskDefinition API and may be shown in the ECS console, but it is not a valid field when registering a new task definition. This field can be safely removed from your task definition file. deploying at region : ap-northeast-2 |
Not sure if still bugging people, but here's my approach:
|
That jq filter is great. But it does seem like it might make sense to do it in the action. Especially if it is never valid to push those values. |
I would use it in that way
otherwise was getting |
@povisenko really cool, works like a charm. Thanks! |
@povisenko thanks, works well for me. |
This is a hack, but a proper fix is still needed |
Working on it: aws-actions/amazon-ecs-render-task-definition#325 |
Just noticed the following warnings started coming back (worked before)
Here is the relevant config is the Github action
.yaml
:The text was updated successfully, but these errors were encountered: