From cf3ec4b71623087b305ce5254f30508478c7618f Mon Sep 17 00:00:00 2001 From: Dane Pilcher Date: Fri, 17 Nov 2023 11:17:29 -0700 Subject: [PATCH] chore: add windows testing checklist item --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1e92b3504..127316ab4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -29,6 +29,7 @@ the requirements below. - [ ] Relevant documentation is changed or added (and PR referenced) - [ ] Breaking changes to existing customers are released behind a feature flag or major version update - [ ] Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified +- [ ] Changes are tested on windows. Some Node functions (such as `path`) behave differently on windows. -By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. \ No newline at end of file +By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.