Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @xstate/react to the latest that support React 19 #6309

Open
1 of 2 tasks
abd-almofleh opened this issue Jan 22, 2025 · 2 comments
Open
1 of 2 tasks

Upgrade @xstate/react to the latest that support React 19 #6309

abd-almofleh opened this issue Jan 22, 2025 · 2 comments
Labels
feature-request Request a new feature

Comments

@abd-almofleh
Copy link

On which framework/platform would you like to see this feature implemented?

React

Which UI component is this feature-request for?

Other

Please describe your feature-request in detail.

In the package @aws-amplify/ui-react-core it gives warning of a Conflicting peer dependency after updating react to V19.

Please describe a solution you'd like.

The package @xstate/[email protected] support React up to ^V18. They released an update @xstate/[email protected] that now add React V19 as a peer dependency.

Thanks

We love contributors! Is this something you'd be interested in working on?

  • 👋 I may be able to implement this feature request.
  • ⚠️ This feature might incur a breaking change.
@abd-almofleh abd-almofleh added the feature-request Request a new feature label Jan 22, 2025
@github-actions github-actions bot added pending-triage Issue is pending triage pending-maintainer-response Issue is pending response from an Amplify UI maintainer labels Jan 22, 2025
@cwomack cwomack removed the pending-triage Issue is pending triage label Jan 22, 2025
@jordanvn
Copy link
Member

Hi @abd-almofleh 👋 We're aware of these peer dependency warnings related to @xstate/react and React 19 compatibility. While these warnings appear during installation, they should not impact the functionality or usage of @aws-amplify/ui-react with React 19. The dependency on @xstate/react is internal to our implementation, and we've verified that the components continue to work as expected with React 19. You can safely ignore these npm warnings.

We appreciate you both bringing this to our attention and will continue to monitor for any actual impact on functionality. If you encounter any specific functional issues, please let us know.

@github-actions github-actions bot removed the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Jan 23, 2025
@abd-almofleh
Copy link
Author

Thank you, @jordanvn. I will keep you posted.

@github-actions github-actions bot added the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Jan 24, 2025
@jordanvn jordanvn removed the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

3 participants