Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple public subnets provisioning #119

Open
pielu opened this issue Jun 14, 2023 · 2 comments
Open

Multiple public subnets provisioning #119

pielu opened this issue Jun 14, 2023 · 2 comments

Comments

@pielu
Copy link

pielu commented Jun 14, 2023

Hello,

There seem to be no way to provision multiple public subnets. This functionality is useful for many use cases, having security (firewall) subnets being one of them. The public subnet code technically iterates over public subnet(s) but it's iterating keys and public is protected key and cannot be used more than once.

@drewmullen
Copy link
Contributor

Hi! thanks for opening this issue! you are correct that we lock down the module to only define 1 set of public subnets using protected keys. ATM we do not have any intention of allowing additional public subnet definitions.

However, I believe the use case you mentioned is one we have considered and planned for using our network firewall module. Here is an example: https://github.com/aws-ia/terraform-aws-networkfirewall/blob/main/examples/central_inspection_with_egress/main.tf

Please let me know if you think that will solve the use case you mentioned!

@pielu
Copy link
Author

pielu commented Jun 22, 2023

Hi! Thanks for coming back so quickly. Yes I have looked at it and in the central firewall architecture that would work. I had a feeling implementing multiple public subnets right now would be a rather ordeal and quite a refactor to the module itself. I have worked around this in my wrapper module, no problem. Just wanted to signal a use case that might be somewhat of a niche. Again, thank you for considering it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants