-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how are policy_manifest changes provisioned? #14
Comments
Thanks for reporting the issue. This is by design. Updating these SSM parameters (OU, Region, or Tag parameter) will trigger FMS policies to be updated with your customization in manifest json file. This is documented in https://docs.aws.amazon.com/solutions/latest/automations-for-aws-firewall-manager/customize-policies.html |
@aijunpeng thank you for the answer. Not 💯 percent clear is to me how you update the policy when you don't need to update the params in parameter store. E.q. you need to add a new policy or smth like that but you keep the settings in the param store because the OU/Region settings do not need to be updated. I know that I could get around this when I would for example add a tag with e.q. version= in the param store and update this one in addition to the policy. But that is a manual task I need to track (possible but error prone). |
Thanks for the feedback. We have added this feature request to our roadmap and will evaluate it for future releases. In the time being, please continue to use the workaround. |
Describe the bug
We have seen in one of our projects that in the case of a policy_manifest update the changes are not getting provisioned into the firewall manager.
To Reproduce
The whole stack is deployed
Expected behavior
The changes are getting provisioned into the FirewallManager
Remark
I had a look into the code.

source/services/policyManager/index.ts starting line 142 there are different events handled. A change of the policy_manifest.json is not handled there.
Please complete the following information about the solution:
Version: v2.0.0
Region: **at least 3 regions. **
Was the solution modified from the version published on this repository? No
If the answer to the previous question was yes, are the changes available on GitHub?Have you checked your service quotas for the services this solution uses? Yes, no issue with the Quotas
Were there any errors in the CloudWatch Logs? How to enable debug mode? No, AFAIK there is no trigger defined
Screenshots

If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).
Additional context
Maybe it is intended to add smth like a policy version as TAG. When updating the policy version this would also trigger the lambda and provision the changes. At least it is not documented.
The text was updated successfully, but these errors were encountered: