Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-glue-alpha: extra_jars parameter in PySparkEtlJob #33225

Open
2 tasks
gontzalm opened this issue Jan 29, 2025 · 2 comments · May be fixed by #33238
Open
2 tasks

aws-glue-alpha: extra_jars parameter in PySparkEtlJob #33225

gontzalm opened this issue Jan 29, 2025 · 2 comments · May be fixed by #33238
Labels
@aws-cdk/aws-glue Related to AWS Glue feature-request A feature should be added or improved. p2

Comments

@gontzalm
Copy link

Describe the feature

Include the extra_jars parameter in the new PySparkEtlJob L2 construct introduced in v2.177.0.

Use Case

We need this parameter in order to use the spark-xml package JAR in our PySpark Glue jobs.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

v2.177.0

Environment details (OS name and version, etc.)

MacOS
@gontzalm gontzalm added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2025
@github-actions github-actions bot added the @aws-cdk/aws-glue Related to AWS Glue label Jan 29, 2025
@pahud pahud self-assigned this Jan 29, 2025
@pahud
Copy link
Contributor

pahud commented Jan 29, 2025

Yes this should be simply expose the L1 to the L2 surface. We welcome the PRs.

@pahud pahud added the p2 label Jan 29, 2025
@pahud pahud removed their assignment Jan 29, 2025
@pahud pahud removed the needs-triage This issue or PR still needs to be triaged. label Jan 29, 2025
This was referenced Jan 30, 2025
Closed
Open
@natalie-white-aws
Copy link
Contributor

Yes this should be simply expose the L1 to the L2 surface. We welcome the PRs.

This is not what L2s are for. They are opinionated constructs and exposing every L1 parameter defeats the purpose of creating interfaces as contracts and enforcing best practices.

@github-actions github-actions bot mentioned this issue Feb 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-glue Related to AWS Glue feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@pahud @gontzalm @natalie-white-aws