Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show runtime defaults in Status field of the EC2NodeClass #1710

Open
bwagner5 opened this issue Apr 21, 2022 · 1 comment
Open

Show runtime defaults in Status field of the EC2NodeClass #1710

bwagner5 opened this issue Apr 21, 2022 · 1 comment
Labels
feature New feature or request v1.x Issues prioritized for post-1.0

Comments

@bwagner5
Copy link
Contributor

bwagner5 commented Apr 21, 2022

Tell us about your request

Some fields in the EC2NodeClass spec (specifically the AWS Cloud Provider), are runtime defaulted, meaning that Karpenter assumes a default value at runtime. Some examples are BlockDeviceMappings, and MetadataOptions.

We should add the resolved runtime defaults to the Status of the EC2NodeClass so that users can understand the defaulting decisions Karpenter has made.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
What outcome are you trying to achieve, ultimately, and why is it hard/impossible to do right now? What is the impact of not having this problem solved? The more details you can provide, the better we'll be able to understand and solve the problem.

Increasing the visibility of runtime defaulted parameters within the EC2NodeClass.

Are you currently working around this issue?
How are you currently solving this problem?

Reading the docs or code are the only way to find this information today.

Additional context
Anything else we should know?

Attachments
If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@bwagner5 bwagner5 added the feature New feature or request label Apr 21, 2022
@bwagner5
Copy link
Contributor Author

#1449

@ellistarn ellistarn reopened this May 15, 2023
@ellistarn ellistarn added the v1 Issues requiring resolution by the v1 milestone label May 15, 2023
@billrayburn billrayburn added v1.x Issues prioritized for post-1.0 and removed v1 Issues requiring resolution by the v1 milestone labels Aug 30, 2023
@njtran njtran changed the title Show runtime defaults in Status field of the Provisioner Show runtime defaults in Status field of the EC2NodeClass Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v1.x Issues prioritized for post-1.0
Projects
None yet
Development

No branches or pull requests

3 participants