Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c7i-flex instances are not correctly labeled with bandwidth #6446

Closed
craigandrews opened this issue Jul 2, 2024 · 2 comments
Closed

c7i-flex instances are not correctly labeled with bandwidth #6446

craigandrews opened this issue Jul 2, 2024 · 2 comments
Labels
bug Something isn't working needs-triage Issues that need to be triaged

Comments

@craigandrews
Copy link

Description

Observed Behavior:

AWS EC2 flex instances (e.g. c7i-flex) do not get a instance-network-bandwidth labels, but other instance types do. The equivalent instance types (e.g. c7i) that do not have flex are properly labeled.

The code in bandwidth_gen.go expects the bandwidth to always be the 5th column in the documentation, but for flex instances it is the 6th column due to the new "Baseline performance" feature.

It appears that flex instances are very new. Documentation example here.

Expected Behavior:

All instances with explicit bandwidth values should have a instance-network-bandwidth label.

Reproduction Steps (Please include YAML):

  • Allow the use of c7i-flex instance types
  • Check the labels of an instance of that type, and there will be no instance-network-bandwidth label

Versions:

  • Chart Version: N/A
  • Kubernetes Version (kubectl version): v1.28.9-eks-036c24b
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@craigandrews craigandrews added bug Something isn't working needs-triage Issues that need to be triaged labels Jul 2, 2024
@craigandrews craigandrews changed the title c7i-flex instances are not correctly tagged with bandwidth c7i-flex instances are not correctly labeled with bandwidth Jul 2, 2024
@matheuss
Copy link

matheuss commented Jul 2, 2024

(I work with @craigandrews) Actually, we just noticed this is fixed on main: #6099 fixed it.

@jigisha620
Copy link
Contributor

Closing this issue since the fix has already been added in #6099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Issues that need to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants