Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRT-Java CredentialsProvider should be an interface #15

Open
kggilmer opened this issue Mar 4, 2021 · 1 comment
Open

CRT-Java CredentialsProvider should be an interface #15

kggilmer opened this issue Mar 4, 2021 · 1 comment

Comments

@kggilmer
Copy link
Contributor

kggilmer commented Mar 4, 2021

tl;dr is that crt-java credentials provider is an abstract class that is tightly coupled to the JNI native bindings and prevents users from supplying a pure JVM implementation of a credentials provider.

This isn't a huge deal yet but it would prevent e.g. customers or the Kotlin SDK team from writing a custom provider implementation.

See:
awslabs/aws-crt-java#252

internal id: 175851816

@aajtodd aajtodd transferred this issue from smithy-lang/smithy-kotlin Jul 8, 2021
@aajtodd
Copy link
Contributor

aajtodd commented Jul 8, 2021

NOTE: that this may not be that big of a deal in practice because the SDK doesn't pass the credential provider to through the signing config. Instead it is called directly and then the credentials returned are passed to the signing config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants