Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuftool: download_root() function should handle file:/// URLs #406

Open
zmrow opened this issue Aug 18, 2021 · 0 comments
Open

tuftool: download_root() function should handle file:/// URLs #406

zmrow opened this issue Aug 18, 2021 · 0 comments

Comments

@zmrow
Copy link
Contributor

zmrow commented Aug 18, 2021

Currently the download_root::download_root() function uses reqwest to pull down the root.json. reqwest doesn't handle file:/// URLs and so unfortunately this means the function can't be used for local repositories which makes unit tests a bit... tough.

The function should probably (suggested by @tjkirch in #404 ) add a branch, where if url.scheme() is file, we just std::fs::copy it instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant