Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore changelog generation #7

Open
maciejwalkowiak opened this issue Oct 9, 2020 · 5 comments
Open

Explore changelog generation #7

maciejwalkowiak opened this issue Oct 9, 2020 · 5 comments
Assignees

Comments

@maciejwalkowiak
Copy link

https://github.com/spring-io/github-changelog-generator

@MatejNedic
Copy link
Member

Generated file for 2.3 looks something like this below:

## :star: New Features

- Draft: Move SqsAutoConfigration to spring.cloud.aws prefix  [#687](https://github.com/spring-cloud/spring-cloud-aws/pull/687)
- Add region configuration property to sqs [#674](https://github.com/spring-cloud/spring-cloud-aws/pull/674)
- Add region configuration property to sns [#673](https://github.com/spring-cloud/spring-cloud-aws/pull/673)
- Add region configuration property to simpleemail [#672](https://github.com/spring-cloud/spring-cloud-aws/pull/672)
- Add region configuration property to cloudwatch [#671](https://github.com/spring-cloud/spring-cloud-aws/pull/671)
- Fix conditional on SimpleEmailAutoConfiguration [#670](https://github.com/spring-cloud/spring-cloud-aws/pull/670)
- Handling custom type labels in headers from Binary/String message attributes. Fix gh-410 [v2]. [#637](https://github.com/spring-cloud/spring-cloud-aws/pull/637)
- Deprecate `@EnableSqs` and `@EnableSns` [#636](https://github.com/spring-cloud/spring-cloud-aws/pull/636)
- Global configuration for deletion policy [#621](https://github.com/spring-cloud/spring-cloud-aws/pull/621)
- Fixes SQS Queues shutting down gracefully [#620](https://github.com/spring-cloud/spring-cloud-aws/pull/620)
- Resolving native SQS message. [#612](https://github.com/spring-cloud/spring-cloud-aws/pull/612)
- Add support for primitives and no specific data type in SQS message attributes [#608](https://github.com/spring-cloud/spring-cloud-aws/pull/608)
- 2.2.x - Map "SentTimestamp" to SqsMessageHeaders #296   [#584](https://github.com/spring-cloud/spring-cloud-aws/pull/584)
- Drop dependency to javax.validation in Parameter Store and Secrets Manager  [#576](https://github.com/spring-cloud/spring-cloud-aws/issues/576)
- Use default AWS SDK credentials and region providers by default [#568](https://github.com/spring-cloud/spring-cloud-aws/issues/568)
- spring-cloud-starter-aws-secrets-manager-config depends on spring-cloud-aws-autoconfigure, breaking app startup in some cases [#526](https://github.com/spring-cloud/spring-cloud-aws/issues/526)
- Set the default queueStopTimeout to >20 secs [#507](https://github.com/spring-cloud/spring-cloud-aws/issues/507)
- Enhancement: make Spring Boot configuration for AWS RDS instance more flexible [#495](https://github.com/spring-cloud/spring-cloud-aws/issues/495)
- Add support for SQS custom data types [#410](https://github.com/spring-cloud/spring-cloud-aws/issues/410)
- Map "SentTimestamp" to SqsMessageHeaders [#296](https://github.com/spring-cloud/spring-cloud-aws/issues/296)
- Populating cache name dynamically in `@EnableElastiCache` annotation [#248](https://github.com/spring-cloud/spring-cloud-aws/issues/248)
- Add ability to configure your own AWSCredentialsProvider [#102](https://github.com/spring-cloud/spring-cloud-aws/issues/102)

## :beetle: Bug Fixes

- bug(dep): org.springframework.http missing when using QueueMessageTemplate [#540](https://github.com/spring-cloud/spring-cloud-aws/issues/540)
- `@SqsListener` and doesn't deserialize the message using java 8 module [#533](https://github.com/spring-cloud/spring-cloud-aws/issues/533)
- SqsListener String index out of bounds issue [#374](https://github.com/spring-cloud/spring-cloud-aws/issues/374)

## :heart: Contributors

We'd like to thank all the contributors who worked on this release!

- [@DarrenForsythe](https://github.com/DarrenForsythe)
- [@maciejwalkowiak](https://github.com/maciejwalkowiak)
- [@eddumelendez](https://github.com/eddumelendez)
- [@MatejNedic](https://github.com/MatejNedic)
- [@voytech](https://github.com/voytech)
- [@mkatircioglu](https://github.com/mkatircioglu)

@maciejwalkowiak
Copy link
Author

Looks awesome! How are contributors sorted?

@maciejwalkowiak
Copy link
Author

Drafts shouldnt be there though..? I'll compare it on Monday with commit list

@MatejNedic
Copy link
Member

MatejNedic commented Oct 16, 2020

I will exclude drafts*, will do it now.
Tbh as for contributors I am not sure. There is no sorting for them in documentation. I think I saw and liked tweet from someone this morning explaining it. Will go take a look.

Contributors are sorted by crate date I assume docs: "By default issues are sorted by their "created" date." so I guess its same for contributors. Will try to find way to sort it by contributions?

@MatejNedic
Copy link
Member

MatejNedic commented Oct 16, 2020

Sry for spam.
New file I generated I added some missing labels that weren't included in first one.
We should probably make bot label any PR that is closed and not closed by Maintainer with "invalid".
This way we can exclude Draft: Move SqsAutoConfigration to spring.cloud.aws prefix [#687](https://github.com/spring-cloud/spring-cloud-aws/pull/687) which is my bad PR I closed.

## New Features

- ElastiCacheCacheConfigurer bean factory should be annotated with ConditionalOnMissingBean [#159](https://github.com/spring-cloud/spring-cloud-aws/issues/159)

## Enhancement

- Draft: Move SqsAutoConfigration to spring.cloud.aws prefix  [#687](https://github.com/spring-cloud/spring-cloud-aws/pull/687)
- Add region configuration property to sqs [#674](https://github.com/spring-cloud/spring-cloud-aws/pull/674)
- Add region configuration property to sns [#673](https://github.com/spring-cloud/spring-cloud-aws/pull/673)
- Add region configuration property to simpleemail [#672](https://github.com/spring-cloud/spring-cloud-aws/pull/672)
- Add region configuration property to cloudwatch [#671](https://github.com/spring-cloud/spring-cloud-aws/pull/671)
- Fix conditional on SimpleEmailAutoConfiguration [#670](https://github.com/spring-cloud/spring-cloud-aws/pull/670)
- Handling custom type labels in headers from Binary/String message attributes. Fix gh-410 [v2]. [#637](https://github.com/spring-cloud/spring-cloud-aws/pull/637)
- Deprecate `@EnableSqs` and `@EnableSns` [#636](https://github.com/spring-cloud/spring-cloud-aws/pull/636)
- Global configuration for deletion policy [#621](https://github.com/spring-cloud/spring-cloud-aws/pull/621)
- Fixes SQS Queues shutting down gracefully [#620](https://github.com/spring-cloud/spring-cloud-aws/pull/620)
- Resolving native SQS message. [#612](https://github.com/spring-cloud/spring-cloud-aws/pull/612)
- Add support for primitives and no specific data type in SQS message attributes [#608](https://github.com/spring-cloud/spring-cloud-aws/pull/608)
- 2.2.x - Map "SentTimestamp" to SqsMessageHeaders #296   [#584](https://github.com/spring-cloud/spring-cloud-aws/pull/584)
- Drop dependency to javax.validation in Parameter Store and Secrets Manager  [#576](https://github.com/spring-cloud/spring-cloud-aws/issues/576)
- Use default AWS SDK credentials and region providers by default [#568](https://github.com/spring-cloud/spring-cloud-aws/issues/568)
- spring-cloud-starter-aws-secrets-manager-config depends on spring-cloud-aws-autoconfigure, breaking app startup in some cases [#526](https://github.com/spring-cloud/spring-cloud-aws/issues/526)
- Set the default queueStopTimeout to >20 secs [#507](https://github.com/spring-cloud/spring-cloud-aws/issues/507)
- Enhancement: make Spring Boot configuration for AWS RDS instance more flexible [#495](https://github.com/spring-cloud/spring-cloud-aws/issues/495)
- Add support for SQS custom data types [#410](https://github.com/spring-cloud/spring-cloud-aws/issues/410)
- Map "SentTimestamp" to SqsMessageHeaders [#296](https://github.com/spring-cloud/spring-cloud-aws/issues/296)
- Populating cache name dynamically in `@EnableElastiCache` annotation [#248](https://github.com/spring-cloud/spring-cloud-aws/issues/248)
- Add ability to configure your own AWSCredentialsProvider [#102](https://github.com/spring-cloud/spring-cloud-aws/issues/102)

## Bug fixes

- bug(dep): org.springframework.http missing when using QueueMessageTemplate [#540](https://github.com/spring-cloud/spring-cloud-aws/issues/540)
- `@SqsListener` and doesn't deserialize the message using java 8 module [#533](https://github.com/spring-cloud/spring-cloud-aws/issues/533)
- SqsListener String index out of bounds issue [#374](https://github.com/spring-cloud/spring-cloud-aws/issues/374)

## Maintenance

- AwsParamStoreBootstrapConfigurationTest tests migrated to applicationContextRunner [#684](https://github.com/spring-cloud/spring-cloud-aws/pull/684)

## :heart: Contributors

We'd like to thank all the contributors who worked on this release!

- [@DarrenForsythe](https://github.com/DarrenForsythe)
- [@maciejwalkowiak](https://github.com/maciejwalkowiak)
- [@eddumelendez](https://github.com/eddumelendez)
- [@MatejNedic](https://github.com/MatejNedic)
- [@voytech](https://github.com/voytech)
- [@mkatircioglu](https://github.com/mkatircioglu)

yaml of generation:

changelog:
  issues:
     exclude:
       labels: ["invalid"]
  sections:
    - title: "New Features"
      labels: ["feature"]
    - title: "Enhancement"
      labels: ["enhancement"]
    - title: "Bug fixes"
      labels: ["bug"]
    - title:  "Maintenance"
      labels: ["maintenance"]
    - title: "Documentation"
      labels: ["documentation"]
    - title: "Dependency upgrades"
      labels: ["dependency-upgrade"]
  repository: "spring-cloud/spring-cloud-aws"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants