Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test io_uring_prep_sendto #1089

Closed
YoSTEALTH opened this issue Mar 7, 2024 · 5 comments
Closed

Test io_uring_prep_sendto #1089

YoSTEALTH opened this issue Mar 7, 2024 · 5 comments

Comments

@YoSTEALTH
Copy link
Contributor

Need to create basic test for io_uring_prep_sendto

@isilence
Copy link
Collaborator

isilence commented Mar 7, 2024

Even though adding such a test would be welcome, but I don't think it's strictly required. It's a simple wrapper, and passing an address is exercised at least in send-zerocopy.c for normal and as well zerocopy modes.

https://github.com/axboe/liburing/blob/master/test/send-zerocopy.c#L375

@YoSTEALTH
Copy link
Contributor Author

Just a basic test should do, nothing fancy, to make sure all the functions are covered with test. I know its not very important but you never know when things will be effected, even a simple type change or new attribute added could effect each other.

@axboe
Copy link
Owner

axboe commented Mar 7, 2024

It's already being implicitly tested. I have a feeling you're asking for this to duplicate it in your framework? If so, please just go ahead and write it and send a PR. We're getting inundated with "please add this or that" these days, and it's not scaleable. If some tests or documentation is missing, please feel free to write them and submit them.

@axboe
Copy link
Owner

axboe commented Mar 7, 2024

#1090

@axboe axboe closed this as completed Mar 7, 2024
@YoSTEALTH
Copy link
Contributor Author

It took me a while to find all those, don't you use something like coverage in C? It normally tells you functions that are not covered in test, figured it would be good to let you guys know.

I would have added all those into 1 issue, but I think you mentioned somewhere to create each post per issue.

I have a feeling you're asking for this to duplicate it in your framework?

No, I don't rewrite the test since it wouldn't make much sense to redo what you have already done. I was trying to do that with futex since there was no documentation, to figure out what io_uring was doing. I mainly test to see if wrapper is working and most of the time trying to figure out how to make C function work best with Cython and Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants