Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppc64le: Tests failed (2): <no-mmap-inval.t> <reg-fd-only.t> #1207

Open
vt-alt opened this issue Aug 17, 2024 · 4 comments
Open

ppc64le: Tests failed (2): <no-mmap-inval.t> <reg-fd-only.t> #1207

vt-alt opened this issue Aug 17, 2024 · 4 comments

Comments

@vt-alt
Copy link

vt-alt commented Aug 17, 2024

JFYI, two tests fail on ppc64 on Linux v6.6.46 for liburing-2.7. They succeed or skipped on x86_64.

+ make runtests
...
[00:01:36] Running test no-mmap-inval.t                                        Got -2, wanted -EFAULT
[00:01:36] Test no-mmap-inval.t failed with ret 1
...
[00:01:49] Running test reg-fd-only.t                                          ring setup failed
[00:01:49] test 8 failed
[00:01:49] Test reg-fd-only.t failed with ret 1

On x86_64:

[00:01:22] Running test no-mmap-inval.t                                        0 sec
...
[00:01:29] Running test reg-fd-only.t                                          Enable huge pages to test big rings
[00:01:29] Skipped
@vt-alt
Copy link
Author

vt-alt commented Aug 19, 2024

Also, the same version suddenly got on aarch64:

[00:00:40] Running test accept-non-empty.t                                     Test accept-non-empty.t failed with ret 78
...
[00:02:40] Tests failed (1): <accept-non-empty.t>

axboe added a commit that referenced this issue Aug 19, 2024
Test for IORING_FEAT_RECVSEND_BUNDLE before setting up the connection
thread, or we could be tearing down pthread data at inopportune moments
leading to odd behavior.

Link: #1207
Fixes: 184e6ec ("test/accept-non-empty: add accept IORING_CQE_F_SOCK_NONEMPTY test")
Signed-off-by: Jens Axboe <[email protected]>
@axboe
Copy link
Owner

axboe commented Aug 19, 2024

Pushed a fix for accept-non-empty, that was a bug in the test.

For ppc64, the -ENOENT for mmap-no-inval is very (very) odd. For reg-fd-only, I'll push a commit to dump 'ret'. Can you try and re-run it? I'm wondering what it's returning. Maybe both are the same arch odditiy and it'll be -ENOENT?!

axboe added a commit that referenced this issue Aug 19, 2024
@vt-alt
Copy link
Author

vt-alt commented Aug 19, 2024

Thanks. Now with ebd6c8f it failed only on ppc64le (and i586 where is usually exclude sqpoll-sleep.t). Kernel is also changed to v6.6.47.

  • ppc64le :
[00:01:36] Running test no-mmap-inval.t                                        Got -2, wanted -EFAULT
[00:01:36] Test no-mmap-inval.t failed with ret 1
...
[00:01:50] Running test reg-fd-only.t                                          ring setup failed: -2
[00:01:50] test 8 failed
[00:01:50] Test reg-fd-only.t failed with ret 1
...
[00:01:52] Running test send-zerocopy.t                                        invalid cqe->res -90 expected 65536
[00:01:52] send failed fixed buf 0, conn 0, addr 1, cork 0
[00:01:52] test_inet_send() failed (defer_taskrun 0)
[00:01:52] Test send-zerocopy.t failed with ret 1
...
[00:02:12] Tests failed (3): <no-mmap-inval.t> <reg-fd-only.t> <send-zerocopy.t>
  • i586:
[00:02:01] Running test sqpoll-sleep.t                                         Test sqpoll-sleep.t failed with ret 1

@isilence
Copy link
Collaborator

isilence commented Aug 19, 2024

Thanks. Now with ebd6c8f it failed only on ppc64le (and i586 where is usually exclude sqpoll-sleep.t). Kernel is also changed to v6.6.47.

* ppc64le :

...

[00:01:52] Running test send-zerocopy.t invalid cqe->res -90 expected 65536
[00:01:52] send failed fixed buf 0, conn 0, addr 1, cork 0

It's UDP for which we "expect" 65536 bytes in a datagram, more than usually supported by UDP. Looks the test wasn't prepared for 16K pages.

if (!tcp && len > 4 * page_sz)
	continue; // skip test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants