Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flameshow seems better than tfg #5

Closed
amosbird opened this issue Nov 21, 2023 · 5 comments
Closed

Flameshow seems better than tfg #5

amosbird opened this issue Nov 21, 2023 · 5 comments
Assignees

Comments

@amosbird
Copy link

https://github.com/laixintao/flameshow

@azat
Copy link
Owner

azat commented Nov 24, 2023

Thanks for the tip, haven't seen it before!

Though there are some issues with it:

Once I will fix this, tfg could be replaced.

But long term goal is to rewrite it to Rust.

@azat azat self-assigned this Nov 24, 2023
azat added a commit to azat-archive/chdig that referenced this issue Nov 24, 2023
azat added a commit to azat-archive/chdig that referenced this issue Nov 25, 2023
* flameshow:
  Add a workaround for incorrect handling of symbols with numbers in flameshow
  Distribute flameshow with PyOxidizer (pyinstaller does not work)
  Replace tfg with flameshow

Fixes: azat#5
azat added a commit to azat-archive/chdig that referenced this issue Nov 25, 2023
* flameshow:
  Explicitly set permissions for files in packages
  Add a workaround for incorrect handling of symbols with numbers in flameshow
  Distribute flameshow with PyOxidizer (pyinstaller does not work)
  Replace tfg with flameshow

Fixes: azat#5
@azat azat closed this as completed in b0e16ef Nov 25, 2023
@amosbird
Copy link
Author

Perfect!

Btw, it seems PyOxidizer allows embedding python code into rust. And it explicitly serves as a python-to-rust helper, which meets the long term goal :

While solving packaging and distribution problems is the primary goal of PyOxidizer, a side-effect of solving that problem with Rust is that PyOxidizer can serve as a bridge between these two languages. PyOxidizer can be used to easily add a Python interpreter to any Rust project. But the opposite is also true: PyOxidizer can also be used to add Rust to Python. Using PyOxidizer, you could bootstrap a new Rust project which contains an embedded version of Python and your application. Initially, your project is a few lines of Rust that instantiates a Python interpreter and runs Python code. Over time, functionality could be (re)written in Rust and your previously Python-only project could leverage Rust and its diverse ecosystem. Since PyOxidizer abstracts the Python interpreter away, this could all be invisible to end-users: you could rewrite an application from Python to Rust and people may not even know because they never see a libpython, .py files, etc.

@azat
Copy link
Owner

azat commented Nov 28, 2023

it seems PyOxidizer allows embedding python code into rust

Indeed!
I already added this into my todo list

@azat
Copy link
Owner

azat commented Nov 28, 2023

P.S. maybe I should convert my todo list into issues on github...

@azat
Copy link
Owner

azat commented Dec 2, 2023

It is not that transparent, but looks like it works more or less OK - ccfa72d (#6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants