Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate vendor extensions #388

Closed
jisantuc opened this issue Aug 20, 2020 · 1 comment
Closed

Validate vendor extensions #388

jisantuc opened this issue Aug 20, 2020 · 1 comment

Comments

@jisantuc
Copy link
Contributor

Improvement

Currently users are limited to extension validation of the few extensions we've mapped into Scala. That's fine for us since those are obviously the Best Extensions ™️ but it's conceivable that at some point in the future one of two things will be true:

  • someone will want to be able to validate a private extension
  • someone will want to be able to validate an extension that hasn't yet ascended to the higher plane of being of the label extension

Those are both reasonable wants!

Notes + Context

I have an idea for how this could work. It relies on:

  • a startup option pointing to a json file containing objects with extension names and links accessible to the Franklin server to the schemas
  • options for the services that serve items / collections to take an "extra extensions" map
  • fallback to the extra extensions map if the built-in extension name checks don't find anything
@jisantuc
Copy link
Contributor Author

Done in #664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant