Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 12 hour format on all cases #12

Open
jpserra opened this issue Jul 13, 2015 · 2 comments
Open

Use 12 hour format on all cases #12

jpserra opened this issue Jul 13, 2015 · 2 comments

Comments

@jpserra
Copy link

jpserra commented Jul 13, 2015

For me it's kind of inconsistent to have toStringreturning a 24h format and getNextreturning 12h format. I think it would be better to stick with only the more universal AM/PM format.
jpserra added a commit to jpserra/prettycron that referenced this issue Jul 13, 2015
@jpserra
Use AM PM time representation
0759ad7 
Closes azza-bazoo#12
jpserra added a commit to jpserra/prettycron that referenced this issue Jul 13, 2015
@jpserra
Use AM PM time representation
445319d 
Closes azza-bazoo#12
@jpserra jpserra mentioned this issue Jul 13, 2015
Open
jpserra added a commit to jpserra/prettycron that referenced this issue Jul 13, 2015
@jpserra
Use AM PM time representation
3fe0f9f 
Closes azza-bazoo#12
@jpserra jpserra mentioned this issue Jul 13, 2015
Merged
@jpserra jpserra reopened this Jul 24, 2015
@pekeler
Copy link
Contributor

pekeler commented Oct 7, 2015

+1 on consistency
-1 on defaulting to AM/PM

@jpserra
Copy link
Author

jpserra commented Oct 7, 2015

@pekeler true, at the time and because of personal need, I came up with this for consistency sake, but better approach would be to make it configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pekeler @jpserra