Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ESLint tests run alongside unit tests and appear in the browser report #390

Open
lolmaus opened this issue Aug 21, 2016 · 5 comments
Open

Comments

@lolmaus
Copy link
Contributor

lolmaus commented Aug 21, 2016

This is how Ember test setup does it, and it's super helpful. Lets you catch lint errors as early as possible.

@jamesplease
Copy link
Member

jamesplease commented Aug 21, 2016

Thanks for the suggestion! Is this specifically for when the browser tests are being run? I haven't yet seen a set up that integrates linting results and test results into an HTML reporter. That sounds really cool, though.

Do you think you might have time to put together a PR, or otherwise link to other resources that might help get this added?

iirc Ember uses Brocolli and something other than Mocha so it may not be as easy to do here. But I'm down to add this if it's possible!

@lolmaus
Copy link
Contributor Author

lolmaus commented Aug 21, 2016

Is this slecifically for when the browser tests are being run?

Yes.

Do you think you might have time to put together a PR

Nope. I'm merely a user, not familiar with test pipeline internals. Ember indeed does some non-trivial manipulation. I only know its test pipeline is based on Testem.

@jamesplease
Copy link
Member

Cool. Thanks for the info! I'll definitely add this to my list of things to research. I think it would be a great addition to the boilerplate.

@jamesplease
Copy link
Member

jamesplease commented Aug 26, 2016

After some initial research this seems to be a feature that would be possible if we were to just add in Testem (thanks for looking into that @lolmaus !) to the boilerplate. It seems like it supports merging all of the results from different sources (linting, test runners like Mocha) together into 1 output.

I'll look more into how much complexity it adds to the build step. @paulfalgout, do you have any initial thoughts?

@paulfalgout
Copy link
Member

oh wow. like the idea.. news to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants