The problems of the saveAll of input #410
babyfish-ct
started this conversation in
Ideas
Replies: 4 comments
-
saveAll保留,但标记 |
Beta Was this translation helpful? Give feedback.
0 replies
-
Solution2, 变更 API 以保证明确 |
Beta Was this translation helpful? Give feedback.
0 replies
-
Solution2 |
Beta Was this translation helpful? Give feedback.
0 replies
-
Solution2 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In Jimmer, saving entity and saving input are different.
As you see, different input type cause the sample result type. So these method cannot be merged into one, and the first method checks the input argument must not be
Input
at runtime.However, for
saveAll
will cause compilation error. Be different with languages support real generic type such as C++/C#, Java erase the generic type so both of these two methods have the same signature whose parametere is
Collection
.Solution1, don't affect the existing users
Solution2, change the API but affect exsiting users.
Beta Was this translation helpful? Give feedback.
All reactions