Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage in btc-staking-ts manager #64

Open
jrwbabylonlab opened this issue Feb 11, 2025 · 0 comments
Open

Improve test coverage in btc-staking-ts manager #64

jrwbabylonlab opened this issue Feb 11, 2025 · 0 comments
Assignees
@0xDazzer

Comments

@jrwbabylonlab
Copy link
Collaborator

jrwbabylonlab commented Feb 11, 2025 •
edited
Loading

We are using the vectors.json in btcstaking/testvectors/vectors.json (https://github.com/babylonlabs-io/babylon/commit/add420f074751cf53edea5b7a55cca3d34291f5b#diff-154e5f5e39cacfe86fe1ec[…]c663e3d05a5a1fb44bd5a67f5420) to test btc-staker, but not btc-staking-ts.

Differential testing would be the way to move forward when testing two implementations that should generate the same outputs.

Recommend improving the test suite by adding differential testing.
@jrwbabylonlab jrwbabylonlab changed the title Comprehensive test coverage in btc-staking-ts manager Improve test coverage in btc-staking-ts manager Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xDazzer 0xDazzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xDazzer @jrwbabylonlab