Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings if enable module using bee without specifying base-url #26

Open
yorkshire-pudding opened this issue Oct 4, 2024 · 2 comments
Labels
type - bug report Something isn't working

Comments

@yorkshire-pudding
Copy link
Collaborator

Steps to reproduce

  1. Start with uninstalled module
  2. Enter bee en domain

Expected result
Enables without warnings but without setting the domain.

Actual result
⚠️ Warning: Trying to access array offset on value of type bool
in domain_default() (line 1191 of /app/docroot/modules/domain/domain.module).

📝 Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
in domain_machine_name() (line 3870 of /app/docroot/modules/domain/domain.module).

✔ The 'Domain Access' module was enabled.

Note this can be easily avoided by adding the base-url option. For example:
bee en domain --base-url=https://example.com

However, we still should handle the error gracefully.

@yorkshire-pudding yorkshire-pudding added the type - bug report Something isn't working label Oct 4, 2024
@izmeez
Copy link
Contributor

izmeez commented Nov 12, 2024

I wonder if this is resolved with the fix in #39 and the PR #46 that is in the beta release?

@yorkshire-pudding
Copy link
Collaborator Author

Hi @izmeez . Tested again after fully uninstalling and then re-enabling and still get the same error. I'll take a look soon, but not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type - bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants