-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Pi-Hole v6 #85
Comments
I will try if I can fit this into my own time schedule. This will probably cause a whole rewrite of the extension as Google will enforce Manifest V3 for extensions. |
I would also like to ask for this update. |
Any news on the v6 support? |
Probably looking into it the next days. |
Me too, so much interested in this extension for chrome. Please, update to get compatibility for v6. |
Something about my pihole setup broke today (ah the perils of auto-updating scripts). I ended up reimaging, and I'm now on v6. |
I am definitely learning based on hits that you have to read the update notes and not update so lightly. And less without backing up. |
Updated to pi-hole V6 and my extension for Firefox stopped working (as excepted). Really appreciate an update soon. Love this extension and use it all the time. |
+1 |
no pressure though and take your time. we appreciate you providing these
extremely useful extensions for free and . take it easy and get it ready
when you feel like it.
Si.
…On Tue, 25 Feb 2025 at 11:08, AlfaJackal ***@***.***> wrote:
+1
—
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ6NUTYCTFCG7JD6N6TATD2RRFKLAVCNFSM6AAAAABXOO5LEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBRGU4TMOBTGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
[image: AlfaJackal]*AlfaJackal* left a comment
(badsgahhl/pihole-browser-extension#85)
<#85 (comment)>
+1
—
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ6NUTYCTFCG7JD6N6TATD2RRFKLAVCNFSM6AAAAABXOO5LEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBRGU4TMOBTGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Many thanks for this extension that we hope to see again working. Bless you. |
I am not a real developer, but an Ops guy. LMK if there is any assistance I can give you on this to lighten the load. |
Thinking out aloud: what are the odds we as users can pressure Pi-hole's devs to stop breaking the API with every major release? It's getting to the point that users have to switch apps every time because volunteer 3rd party app devs can't keep up. |
Indeed, adapting to such changes is effort. But V6 had its beta phase started almost a year ago, so this is not a sudden surprise. And you would also need to look for alternatives if a project gets abandoned but it seems this is not the case here 😉 |
This is not as easy as you think. Additionally to that, this is a major release and totally fine to have breaking changes... and as @upD8R mentioned, pihole v6 beta was available in beta since nearly 1 year giving everyone enough time to adopt the changes. @badsgahhl if there is something where you need assistance, maybe make a quick list of what you need and maybe we find some people than can assist. |
Thanks very much indeed - will this show up in the webstore, too? |
After Google has approved it. Webstore is by far the slowest so it will take up to 5 days. |
Many thanks |
Thanks for the update, but I keep getting UPDATEWell the 1st one of the above wound up working out of nowhere. |
Yea the new authentication is special. Rather than using stateless tokens its using a cookie session token hybrid mix. The usage of the admin dashboard & extension in parallel can do weird stuff as they share the same cookies. Currently I implemented the bare minimum to handle the session, but there could be stuff improved if these connection errors occur more often. Changing any setting within the settings page of the extension will reset the local saved session and probably fix the error. |
@badsgahhl OK I see. Thanks for the explanation! |
@badsgahhl regarding your cookie session token hybrid statement: I tried setting the extension up on a 2nd machine and it connected only after I logged into the Pi-hole web interface in a separate tab of the same browser. |
There will be one patch to solve some auth related stuff. This will prevent the cookie dilemma and only uses the session the extension really knows. |
It's updated on the Firefox & Google Chrome store. Could you also push the update to the Microsoft Edge store. Thanks so much for this! |
It's already published and waiting for the approval for it's release. The edge store is even slower than Webstore and will take up to 7 working days. |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Pi-Hole v6 is in development and publicly available. It involves a completely rewritten REST-based API and this extension will require an update to function.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Support for Pi-Hole v6 by the time it is formally released, or soon thereafter.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
There isn't an alternative if this extension will be supported on Pi-Hole v6.
Additional context
Add any other context or screenshots about the feature request here.
Thanks for all your hard work on this plugin. It's invaluable for people like me. I'm hoping you're looking at v6-development and planning for a migration to the new API!
The text was updated successfully, but these errors were encountered: