Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Pi-Hole v6 #85

Closed
squawkingVFR opened this issue Dec 6, 2023 · 26 comments · Fixed by #98
Closed

Support for Pi-Hole v6 #85

squawkingVFR opened this issue Dec 6, 2023 · 26 comments · Fixed by #98
Labels
enhancement New feature or request

Comments

@squawkingVFR
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Pi-Hole v6 is in development and publicly available. It involves a completely rewritten REST-based API and this extension will require an update to function.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Support for Pi-Hole v6 by the time it is formally released, or soon thereafter.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

There isn't an alternative if this extension will be supported on Pi-Hole v6.

Additional context
Add any other context or screenshots about the feature request here.

Thanks for all your hard work on this plugin. It's invaluable for people like me. I'm hoping you're looking at v6-development and planning for a migration to the new API!

@squawkingVFR squawkingVFR added the enhancement New feature or request label Dec 6, 2023
@badsgahhl
Copy link
Owner

I will try if I can fit this into my own time schedule. This will probably cause a whole rewrite of the extension as Google will enforce Manifest V3 for extensions.

@StanVokac
Copy link

I would also like to ask for this update.
Pi-Hole v6 seems to be a big step ahead and it would be amazing to have this browser extension functional with it.
Many thanks for your consideration.

@badsgahhl badsgahhl pinned this issue Jan 13, 2024
@badsgahhl badsgahhl linked a pull request Jan 14, 2024 that will close this issue
@Skylinar
Copy link

Any news on the v6 support?

@badsgahhl
Copy link
Owner

Probably looking into it the next days.

This was referenced Feb 22, 2025
@TioBundy
Copy link

Me too, so much interested in this extension for chrome. Please, update to get compatibility for v6.

@t-makaro
Copy link

Something about my pihole setup broke today (ah the perils of auto-updating scripts). I ended up reimaging, and I'm now on v6.

@TioBundy
Copy link

Hoy algo falló en mi configuración de Pihole (ah, los peligros de las actualizaciones automáticas de scripts). Terminé por volver a crear la imagen y ahora estoy en la versión 6.

I am definitely learning based on hits that you have to read the update notes and not update so lightly. And less without backing up.

@eugef66
Copy link

eugef66 commented Feb 25, 2025

Updated to pi-hole V6 and my extension for Firefox stopped working (as excepted). Really appreciate an update soon. Love this extension and use it all the time.

@AlfaJackal
Copy link

+1

@siborg
Copy link

siborg commented Feb 25, 2025 via email

@rivman
Copy link

rivman commented Feb 28, 2025

Many thanks for this extension that we hope to see again working. Bless you.

@Guyverix
Copy link

Guyverix commented Mar 1, 2025

I am not a real developer, but an Ops guy. LMK if there is any assistance I can give you on this to lighten the load.

@jdrch
Copy link

jdrch commented Mar 1, 2025

Thinking out aloud: what are the odds we as users can pressure Pi-hole's devs to stop breaking the API with every major release? It's getting to the point that users have to switch apps every time because volunteer 3rd party app devs can't keep up.

@upD8R
Copy link

upD8R commented Mar 1, 2025

Indeed, adapting to such changes is effort. But V6 had its beta phase started almost a year ago, so this is not a sudden surprise.
If such a project is done in sparetime, developers priorities can easily shift and this is fine. In the end we use something, which was most likely created for one person and then offered (for free) to others. No obligations here.

And you would also need to look for alternatives if a project gets abandoned but it seems this is not the case here 😉

@Skylinar
Copy link

Skylinar commented Mar 1, 2025

Thinking out aloud: what are the odds we as users can pressure Pi-hole's devs to stop breaking the API with every major release? It's getting to the point that users have to switch apps every time because volunteer 3rd party app devs can't keep up.

This is not as easy as you think. Additionally to that, this is a major release and totally fine to have breaking changes... and as @upD8R mentioned, pihole v6 beta was available in beta since nearly 1 year giving everyone enough time to adopt the changes.

@badsgahhl if there is something where you need assistance, maybe make a quick list of what you need and maybe we find some people than can assist.

@badsgahhl
Copy link
Owner

https://github.com/badsgahhl/pihole-browser-extension/releases/tag/4.0.0

@upD8R
Copy link

upD8R commented Mar 1, 2025

Thanks very much indeed - will this show up in the webstore, too?

@badsgahhl
Copy link
Owner

Thanks very much indeed - will this show up in the webstore, too?

After Google has approved it. Webstore is by far the slowest so it will take up to 5 days.

@eugef66
Copy link

eugef66 commented Mar 1, 2025

Many thanks

@jdrch
Copy link

jdrch commented Mar 1, 2025

Thanks for the update, but I keep getting Connection failed on Firefox. I'm running Pi-hole v6 and using https://my.pi-hole.ip.address/admin and my web UI password. Using the API key instead of the password results in the same. Any ideas what I'm doing wrong?

UPDATE

Well the 1st one of the above wound up working out of nowhere.

@badsgahhl
Copy link
Owner

badsgahhl commented Mar 1, 2025

Yea the new authentication is special. Rather than using stateless tokens its using a cookie session token hybrid mix. The usage of the admin dashboard & extension in parallel can do weird stuff as they share the same cookies.

Currently I implemented the bare minimum to handle the session, but there could be stuff improved if these connection errors occur more often.

Changing any setting within the settings page of the extension will reset the local saved session and probably fix the error.

@jdrch
Copy link

jdrch commented Mar 1, 2025

@badsgahhl OK I see. Thanks for the explanation!

@jdrch
Copy link

jdrch commented Mar 2, 2025

@badsgahhl regarding your cookie session token hybrid statement: I tried setting the extension up on a 2nd machine and it connected only after I logged into the Pi-hole web interface in a separate tab of the same browser.

@badsgahhl
Copy link
Owner

There will be one patch to solve some auth related stuff. This will prevent the cookie dilemma and only uses the session the extension really knows.

@ImpetuousRacer
Copy link

ImpetuousRacer commented Mar 3, 2025

It's updated on the Firefox & Google Chrome store. Could you also push the update to the Microsoft Edge store. Thanks so much for this!
https://microsoftedge.microsoft.com/addons/detail/pihole-browser-extension/jbelapanpabbnchmaalboimjmgmbfjnm

@badsgahhl
Copy link
Owner

It's updated on the Firefox & Google Chrome store. Could you also push the update to the Microsoft Edge store. Thanks so much for this! https://microsoftedge.microsoft.com/addons/detail/pihole-browser-extension/jbelapanpabbnchmaalboimjmgmbfjnm

It's already published and waiting for the approval for it's release. The edge store is even slower than Webstore and will take up to 7 working days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet