Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it feature complete with the vault API #5

Open
gerrrg opened this issue Aug 27, 2021 · 2 comments
Open

Make it feature complete with the vault API #5

gerrrg opened this issue Aug 27, 2021 · 2 comments

Comments

@gerrrg
Copy link
Collaborator

gerrrg commented Aug 27, 2021

We're missing few misc functions for the vault that would be nice to have just for the sake of being feature complete. (getAuthorizer, hasApprovedRelayer, etc.)
@gerrrg
Copy link
Collaborator Author

gerrrg commented Aug 27, 2021 •
edited
Loading

https://dev.balancer.fi/references/contracts/apis/the-vault

@gerrrg
Copy link
Collaborator Author

gerrrg commented Jun 1, 2022

Easy ones:

getAuthorizer()
hasApprovedRelayer()
setRelayerApproval()
getPool()
getPoolTokenInfo()
getProtocolFeesCollector()
setPaused()

A bit more time consuming:
exitPool()

For exitPool, use joinPool as an example

@ribeirojose ribeirojose mentioned this issue May 4, 2023
Merged
gerrrg pushed a commit that referenced this issue Jun 27, 2023
@yvesfracari
address #45 review comments (#5)
4dc7c59 
* remove remaining **kwargs

* change exit pool print

* clarify maxBptAmount in BPT_IN_FOR_EXACT_TOKENS_OUT exit

* fix suffiecient balance for maxBptAmount kwyword for BPT_IN_FOR_EXACT_AMOUNT_OUT

* remove unused List typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gerrrg