Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering annotations are broken #118

Open
weiju opened this issue Feb 14, 2017 · 2 comments
Open

Entering annotations are broken #118

weiju opened this issue Feb 14, 2017 · 2 comments
Labels

Comments

@weiju
Copy link
Member

weiju commented Feb 14, 2017

Annotations don't work, there must be a problem in the whole process since the errors
date back to October 2016.

The problem is that this also causes the system to break in the analyze view

@weiju weiju added the bug label Feb 14, 2017
@weiju
Copy link
Member Author

weiju commented Feb 14, 2017

Ok, it seems that there is more going on here:
This is simply sloppy execution: Instead of storing annotations in its respective table and retrieving the possible values there, it is hardcoded in annotation.js.

The annotation table itself is empty. I So the system_annotations.annotation_id is actually not a foreign key, but conceptually a table of references to hardcoded values that only exist in a Javascript file with its description conceptually stored/hardcoded in sys_annotations.html.

This is wrong on all levels, luckily we haven't used the annotations system much so far. I suggest we entirely redesign and rewrite the annotations part instead of trying to fix it.

@weiju
Copy link
Member Author

weiju commented Feb 15, 2017

After thinking a while about this I will create a dedicated service with an API to track changes and this project will only serve as its user interface. This is also a pilot for moving the social and the measurement system into dedicated services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant