Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis views: data filtering #119

Open
weiju opened this issue Mar 1, 2017 · 0 comments
Open

Analysis views: data filtering #119

weiju opened this issue Mar 1, 2017 · 0 comments

Comments

@weiju
Copy link
Member

weiju commented Mar 1, 2017

Analysis views are implemented wrong:

  1. it uses client-side filtering. Since data is filtered based on system status, this can and should be done
    by the database
  2. The views.py is incorrectly implemented as well: There is plenty of hardcoded stuff going on there

This results in incomplete chart rendering and is most apparent in the splitting not working after eliminating some of the redundant Javascript code.
The solution is to use proper filtering code which should further reduce the amount of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant