Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to switch wallets #272

Open
Tracked by #550
aguzmant103 opened this issue Aug 16, 2023 · 8 comments
Open
Tracked by #550

Allow to switch wallets #272

aguzmant103 opened this issue Aug 16, 2023 · 8 comments
Assignees
Labels
feature 🚀 This is enhancing something existing or creating something new refactoring ♻️ A code change that neither fixes a bug nor adds a feature

Comments

@aguzmant103
Copy link
Collaborator

aguzmant103 commented Aug 16, 2023

  1. After connecting a wallet with the wrong address, I want to switch the address
  2. The UI isn't allowing me to do that

The "connected as" in the top right should be dropdown that allows me to switch wallets

https://discord.com/channels/943612659163602974/1139581328908628078/1141033262240772206

@aguzmant103 aguzmant103 added this to the 3. Tethys milestone Aug 16, 2023
@aguzmant103 aguzmant103 added the bug 🐛 Something isn't working label Aug 16, 2023
@aguzmant103 aguzmant103 changed the title Switch wallets easily Allow to switch wallets Aug 16, 2023
@aguzmant103 aguzmant103 added feature 🚀 This is enhancing something existing or creating something new and removed bug 🐛 Something isn't working labels Aug 22, 2023
@aguzmant103
Copy link
Collaborator Author

Maybe it could be done with: https://www.rainbowkit.com/docs/installation#add-the-connect-button (RainbowKit will now handle your user's wallet selection, display wallet/transaction information and handle network/wallet switching.)

@aguzmant103 aguzmant103 added the good first issue Good for newcomers label Aug 22, 2023
@0xkf
Copy link

0xkf commented Sep 27, 2023

I would like to try this.

@vplasencia vplasencia modified the milestones: 3. Tethys, 4. Dione Jan 2, 2024
@vplasencia vplasencia removed this from the 4. Dione milestone Mar 17, 2024
@aguzmant103 aguzmant103 added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 3, 2024
@antonyjaen
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have been working as fullstack developer for WEB2 for 3 years, I'll like to explore WEB3 world so looks like a fun and benefit project to start with 🙂

@vplasencia
Copy link
Member

Hey @antonyjaen! Do you want me to assign this issue to you?

@antonyjaen
Copy link

@vplasencia Sure!

@vplasencia
Copy link
Member

Hey! Done. Thank you. Feel free to ask any questions you may have.

@antonyjaen
Copy link

I found that the versions of wagmi (installed: 0.12.12 - current 2.12.7) and @rainbow-me/rainbowkit (installed: 0.12.8 - current 2.1.5) in the 'dashboard' are outdated and could be a limitation. I think it might be a good idea to update them. What do you think? @vplasencia

@vplasencia vplasencia added refactoring ♻️ A code change that neither fixes a bug nor adds a feature feature 🚀 This is enhancing something existing or creating something new and removed good first issue Good for newcomers feature 🚀 This is enhancing something existing or creating something new labels Sep 13, 2024
@vplasencia vplasencia assigned vplasencia and unassigned antonyjaen Sep 13, 2024
@vplasencia
Copy link
Member

vplasencia commented Sep 13, 2024

Hey @antonyjaen! Yes, I think it's better to update those dependencies. Since updating the dependencies can cause updating many parts of the project and take a lot of time because there was a similar situation when trying to update ethers recently, I removed the good first issue label and created a new issue (See here: #550) to solve some issues related to the Wallet. I also added your comment there.

I assigned the new issue, this and another similar one related to the wallet to myself because there can be many updates in the app and take more time than expected, and I don't think they will be good first issues anymore.

Sorry about that. If you are still interested in contributing, please take a look at the good first issues here and feel free to ask for any other. I will be adding more good first issues soon. Thank you very much 🙏

@vplasencia vplasencia modified the milestone: 5. Rhea Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

No branches or pull requests

4 participants