Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Daemon Secret Renewer Interface for Centralized Process Control #117

Open
csatib02 opened this issue Apr 5, 2024 · 0 comments
Open

Extend Daemon Secret Renewer Interface for Centralized Process Control #117

csatib02 opened this issue Apr 5, 2024 · 0 comments
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.

Comments

@csatib02
Copy link
Member

csatib02 commented Apr 5, 2024 •
edited
Loading 

          we should probably extend the renewer interface to expose a way to get this signal rather than allowing renewer to kill the processes (because thats also something that vault provider does). this process kill should happen centrally somewhere in main. will share more details for a follow up PR.

Originally posted by @ramizpolic in #92 (comment)
@csatib02 csatib02 mentioned this issue Apr 5, 2024
Merged
@csatib02 csatib02 added the kind/enhancement Categorizes issue or PR as related to an improvement. label Apr 30, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jun 30, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 30, 2024
@csatib02 csatib02 added lifecycle/keep Denotes an issue or PR that should be preserved from going stale. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csatib02