Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect logic behavior in the screenshot method. #15

Open
andrews239 opened this issue Apr 2, 2024 · 0 comments
Open

Incorrect logic behavior in the screenshot method. #15

andrews239 opened this issue Apr 2, 2024 · 0 comments

Comments

@andrews239
Copy link

1:        self.video.refresh(x, y, width, height)
2:        while True:
3:            update_type = await self.read()
4:            if update_type is UpdateType.VIDEO:
5:                if self.video.is_complete():
6:                    return self.video.as_rgba()

line 1: Sends refresh for ROI
line 5: Expects update for Full Frame.

Yes, some servers choose to send the entire frame update. But the RFC does not require such behavior and such server behavior is difficult to consider reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant