-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node-entrypoint is broken #143
Comments
Thanks for reporting @feld. Tried to repro your issue locally and it seems ok for me in bash. e.g.
However the proposed change seems to not work as expected.
Are you by any change overriding OP_NODE_L2_ENGINE_RPC and does it have a second http in the URL? I wonder if we should switch the
|
the errors I received were related to my OP_NODE_L2_ENGINE_RPC still being http://geth:8551 in my deployment instead of ws:// AND it requires bash now because the ${TEST//http/ws} format is not POSIX. Only #, ##, %, and %% are POSIX. There is no mention of this breaking change in the release notes published with the v0.5.0 tag: https://github.com/base-org/node/releases/tag/v0.5.0 |
Hmmm were there any other changes? That should still not have been a breaking change: > OP_NODE_L2_ENGINE_RPC=http://geth:8551
> echo ${OP_NODE_L2_ENGINE_RPC//ws/http}
http://geth:8551 |
This was broken in #119
First, the shell script syntax is broken.
this obviously should be
Secondly, this won't work anyway because this endpoint returns a 404.
This change was not tested. Your v0.5.0 release has been out for a month.
Nobody noticed this for a month which is DEEPLY concerning. Is anyone actually running this chain?
The text was updated successfully, but these errors were encountered: