Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the following dialyzer errors #82

Closed
andrewjstone opened this issue Dec 5, 2013 · 2 comments
Closed

Fix the following dialyzer errors #82

andrewjstone opened this issue Dec 5, 2013 · 2 comments
Milestone

Comments

@andrewjstone
Copy link
Contributor

We aren't checking return values for these which implies we should just match on ok and fail fast.

dialyzer -Wno_return -Wunmatched_returns -Wrace_conditions \
        --plt /Users/ajs/.eleveldb_dialyzer_plt ebin | tee .dialyzer.raw-output
  Checking whether the PLT /Users/ajs/.eleveldb_dialyzer_plt is up-to-date... yes
  Proceeding with analysis...
eleveldb.erl:126: Expression produces a value of type {'error',_} | {'ok',eleveldb:db_ref()}, but this value is unmatched
eleveldb.erl:156: Expression produces a value of type 'ok' | {'error',_}, but this value is unmatched
eleveldb.erl:174: Expression produces a value of type {_,'ok',eleveldb:itr_ref()}, but this value is unmatched
eleveldb.erl:180: Expression produces a value of type {_,'ok',eleveldb:itr_ref()}, but this value is unmatched
 done in 0m1.24s
done (warnings were emitted)
andrewjstone added a commit that referenced this issue Dec 5, 2013
@evanmcc evanmcc added this to the 2.0-RC milestone May 12, 2014
@evanmcc
Copy link

evanmcc commented May 12, 2014

@andrewjstone have these been fixed?

@andrewjstone
Copy link
Contributor Author

I don't see them anymore when running dialyzer on develop, so I suppose this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants