Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a cache layer for generated SQL #6

Open
3 tasks
GrandChaman opened this issue May 3, 2021 · 0 comments
Open
3 tasks

Add a cache layer for generated SQL #6

GrandChaman opened this issue May 3, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@GrandChaman
Copy link
Member

We don't need to always regenerate SQL queries when the requests options are the same and only the parameters have changed.

  • Save the parameters as functions that can extract the real parameters from the Ciboulette2PgBuilderState
  • Add a LRU cache layer to store the generated SQL
  • Add a method to re-extract the parameter for given requests options
@GrandChaman GrandChaman added enhancement New feature or request good first issue Good for newcomers labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GrandChaman