Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow to ingest numeric when formatted with the percentage symbl #188

Open
jflairie opened this issue Aug 11, 2020 · 1 comment
Labels
documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request good first issue 🥇 Good for newcomers help wanted 👋🏻 Extra attention is needed
Milestone

Comments

@jflairie
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When importing a column with numerical values formatted like 80%, the import will fail when you declare this column as numerical. As of now, we need to transform it to 0.8 to make it work. While understandable from a technical standpoint (everything is read as a string before conversion), this can be less convenient for end-users: in some cases 80% is more readable than 0.8

Describe the solution you'd like
When a column is specified as numerical, the import should work for values formatted with a % symbol

@bastienboutonnet bastienboutonnet added this to the Objekt milestone Aug 11, 2020
@bastienboutonnet
Copy link
Owner

Good one. Gonna have to see if:

  • is it still a problem as of >=1.0.0 since I handle data type casting on the dataframe directly rather than let the db do its thing.
  • given that we can control this earlier in this new version, would the percent signs be an issue?
  • if so, would we want to support a light enforcemt whereby if (and only if) you specifically ask for a datatype we would throw away special chars, round stuff etc.

@bastienboutonnet bastienboutonnet added documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request good first issue 🥇 Good for newcomers help wanted 👋🏻 Extra attention is needed labels Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request good first issue 🥇 Good for newcomers help wanted 👋🏻 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants