Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Class Name Adding #36

Open
rafegoldberg opened this issue Apr 12, 2016 · 0 comments
Open

Better Class Name Adding #36

rafegoldberg opened this issue Apr 12, 2016 · 0 comments

Comments

@rafegoldberg
Copy link

lemme start by saying fixTo.js is awesome– simple to use and effective in it's result, like every plugin ought to be! the two requests I have are as follows:

  • add class name to fixed elements even when using native position:sticky

    Reasoning: I use the className option to hook certain CSS styles to the fixed state, such as a box-shadow or something. On mobile, not adding the className appears to "break" the styling. You can easily accomplish a similar effect using scrollstart and scrollstop events, but it would be nice to have it baked in to the plugin itself!

  • add a class name like .fixTo-shim (or some such thing) to the DOM element that is generated and inserted before any fixed element

    Reasoning: imagine the height of my nav changes when it's fixed (some elements become vertically smaller). Currently, I can reflow the nav using the refresh trigger. But let's say I wanted to apply a transition property to minimize the bounce when the height changes, there's no way to do this consistently!

Hope that all makes sense. Again, I love the plugin!

@rafegoldberg rafegoldberg changed the title Better Class Naming Scheme Better Class Name Adding Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant