Element is not "unfixed" when back to top

[adi-]

Getting to top stopped working. I think it started with FF 58, maybe 57. Also it doesn't work on recent Chrome.

[bbarakaci]

What do you mean by "getting to top". Example implementations seem to work in both browsers: http://bbarakaci.github.io/fixto/dev2.html

…

On Mon, Jan 29, 2018 at 9:51 PM, adi ***@***.***> wrote: Getting to top stopped working. I think it started with FF 58, maybe 57. Also it doesn't work on recent Chrome. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABtwNCgZtkbhVjnpV48Bi2urRKSvrDwpks5tPi9NgaJpZM4RxVVc> .

[adi-]

in my situation, when this._scrollTop reaches 0, fixto-fixed class is not removed from element.

[adi-]

So, this is not a problem of a web browser, but related to parent element. I have sticked top navigation to body. There is no gap above nav nor body. Fixedto.js cannot unfix nav in such situation. However, if I add 1px gap above body it starts working. I guess, there could be a problem in calculations. Fixedto.js should unfix elements when it is 0px related to parent and not below.

[adi-]

When I change the line

fixto/src/fixto.js

Line 442 in 2ef6935

if (this._scrollTop > this._parentBottom || this._scrollTop < (this._fullOffset('offsetTop', this._ghostNode) - this.options.top - this._mindtop())) {

to:

if (this._scrollTop > this._parentBottom || this._scrollTop <= (this._fullOffset('offsetTop', this._ghostNode) - this.options.top - this._mindtop())) {

it works.

[bbarakaci]

Cool that you have found the solution. When I find some time I will see if the solution plays well with each case. Then I can push a fix for everybody. Thanks.

…

On Tue 30. Jan 2018 at 10:32, adi ***@***.***> wrote: When I change the line https://github.com/bbarakaci/fixto/blob/2ef69350091d4dadc9f170a8496cba64f07aa73c/src/fixto.js#L442 to: if (this._scrollTop > this._parentBottom || this._scrollTop <= (this._fullOffset('offsetTop', this._ghostNode) - this.options.top - this._mindtop())) { it works. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABtwNHBJO3YL_FhlTJa6wmN7l_WBZEcqks5tPuHFgaJpZM4RxVVc> .

[adi-]

Sure thing! Hope it could help not only me.

[aliencosmo]

unsubscribe

…

On Wed, Jan 31, 2018 at 7:04 AM, adi ***@***.***> wrote: Sure thing! Hope it could help not only me. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABxqsTQ6MmKVPmD9OHqM2BAPUwRdYUiaks5tQFbKgaJpZM4RxVVc> .