Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove InlineWorker from closure in getAudioDecoder #61

Open
davidturissini opened this issue Jan 10, 2019 · 2 comments
Open

Remove InlineWorker from closure in getAudioDecoder #61

davidturissini opened this issue Jan 10, 2019 · 2 comments

Comments

@davidturissini
Copy link
Contributor

getAudioDecoder creates an InlineWorker on every invocation. This is ok for processing a single waveform, but it quickly becomes a problem when multiple waveforms are processed. It would be better if the worker was created only once.
@davidturissini davidturissini mentioned this issue Jan 12, 2019
Open
@chrisn
Copy link
Member

chrisn commented Jan 13, 2019

Ah, good point. I'm happy to pick this up, unless you're already working on it?

@davidturissini
Copy link
Contributor Author

@chrisn go for it. I have a couple ideas but haven’t started yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisn @davidturissini