Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot to theme QuickSwitch border size and colour? #736

Open
fladd opened this issue Jun 10, 2023 · 8 comments
Open

Hot to theme QuickSwitch border size and colour? #736

fladd opened this issue Jun 10, 2023 · 8 comments
Labels
enhancement The report requests an enhancement beyond the intended behaviour.

Comments

@fladd
Copy link

fladd commented Jun 10, 2023

I cannot seem to find a way to change the border size and colour of the QuickSwitch window. It does not follow the normal window settings.

@gijsbers
Copy link
Collaborator

Does grep -e Color.*Quick -e Quick.*Marg ~/.icewm/preferences help?

@fladd
Copy link
Author

fladd commented Jun 12, 2023

Unfortunately not. It gives me this:
image

Nothing on borders I am afraid.

@gijsbers
Copy link
Collaborator

OK, it's just a generic function with the color derived from the generic switch background:

    g.setColor(switchBg);
    g.drawBorderW(0, 0, width() - 1, height() - 1, true);

@fladd
Copy link
Author

fladd commented Jun 12, 2023 via email

@gijsbers
Copy link
Collaborator

Maybe other looks need a fix as well. fully themed is undefined and could be a lot of unattractive work with unclear benefits. The QuickSwitch already has 12 themables and 13 preferences. Thanks for this observation.

@fladd
Copy link
Author

fladd commented Jun 13, 2023

Well, "fully" might have been not the best choice of word. I meant that it would be great if it were consistent with what can be styled on the other elemens (e.g. windows/menu), such that one can create themes that look coherent.

@gijsbers gijsbers added the enhancement The report requests an enhancement beyond the intended behaviour. label Aug 17, 2023
@Code7R
Copy link
Collaborator

Code7R commented Oct 7, 2024

I am not sure that his is an enhancement only. For certain themes, even the included ones, quick-switch looks outright ugly (low contrast, hard to read). Example: NanoBlue, although the actual cause is the color configured in the theme - when the background pixmap is not used, the raw color is simply bad.

@fladd Would it make sense to simply mimic the menu look in the quickswitch overlay? I.e. matching Look and color scheme completely?

@fladd
Copy link
Author

fladd commented Oct 13, 2024

@Code7R Yes, that would make sense, but keep in mind that the menu look is actually affected by several things that interact in a complex (and not very intuitive) way. For instance, to get a 1px border in colour X around the menu, one would need to set "ColorActiveMenuItem" to X while at the same time have "ColorNormalMenu" set and have a "menubg.xpm" file present.

In this context it is also worth noting that the colour you set in "ColorNormalMenu" will actually not be put on screen as is, but a significantly lighter version of it will appear on screen. So for instance, if you want it to appear on screen as #C4C3C8, you need to set it to #939297 for some reason.

So yes, it would be nice if the QuickSwitch would follow the menu, but it would then also need to mirror all these complex oddities :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The report requests an enhancement beyond the intended behaviour.
Projects
None yet
Development

No branches or pull requests

3 participants