Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme dashboard and home page #215

Closed
2 tasks done
CraigClark opened this issue Nov 2, 2023 · 0 comments · Fixed by #255, #263 or #270
Closed
2 tasks done

Theme dashboard and home page #215

CraigClark opened this issue Nov 2, 2023 · 0 comments · Fixed by #255, #263 or #270
Assignees
Labels
alpha Alpha release as per Sprint With Us is anticipated Dec 31, 2023 Priority: high This issue has a high user or business impact and requires a hot fix Sprint 8 October 20 to November 9 Sprint 9 November 10 to November 30 Sprint 10 December 1 - December 31 task a task that a dev team member needs to address
Milestone

Comments

@CraigClark
Copy link
Collaborator

CraigClark commented Nov 2, 2023

OP timer

https://openplus.monday.com/boards/4092908516/pulses/5441681289


An HTML prototype has been created in addition to the Figma that applies the styles necessary to implement the theme done in figma. the html files are in the theme/html branch. See the folder theme_html at the root. As much as possible, use existing bootstrap classes.

Note on page variant

The layout should be done using page manager

  • Page manager should have variant for anonymous (use home-anonymous.html styles)
  • Page manager should have variant for authenticated user (use home-dashboard.html styles)

Not all blocks are available to all users on the dashboard. The assumption is that once all the correct classes are applied by a developer, the theme will work.

Figma references


Note

be sure to check the readme.md file on the theme_html directory.

The dashboard is specific to the data catalogue and does not need to be part of the base-build

Additional

The grey block on the dashboard to add the block will require the module that uses a webform to create a node. This is done, see #226

@CraigClark CraigClark added task a task that a dev team member needs to address Sprint 8 October 20 to November 9 labels Nov 2, 2023
@CraigClark CraigClark added this to the Theming milestone Nov 2, 2023
@NicoledeGreef NicoledeGreef added Sprint 9 November 10 to November 30 Priority: high This issue has a high user or business impact and requires a hot fix labels Nov 9, 2023
@NicoledeGreef NicoledeGreef added the alpha Alpha release as per Sprint With Us is anticipated Dec 31, 2023 label Nov 21, 2023
@CraigClark CraigClark assigned gurjinder12 and unassigned lkmorlan Nov 22, 2023
@gurjinder12 gurjinder12 moved this from Todo to In Progress in MFIN Data Catalogue Nov 27, 2023
@lkmorlan lkmorlan linked a pull request Dec 1, 2023 that will close this issue
lkmorlan pushed a commit that referenced this issue Dec 7, 2023
lkmorlan pushed a commit that referenced this issue Dec 7, 2023
lkmorlan added a commit that referenced this issue Dec 7, 2023
lkmorlan pushed a commit that referenced this issue Dec 7, 2023
lkmorlan added a commit that referenced this issue Dec 7, 2023
Everyone will see the anonymous dashboard on the homepage.
lkmorlan added a commit that referenced this issue Dec 7, 2023
This allows them to update the needs-review strings that are in Views.
lkmorlan added a commit that referenced this issue Dec 7, 2023
This allows them to change the allowed values list field_review_status.
lkmorlan added a commit that referenced this issue Dec 7, 2023
@github-project-automation github-project-automation bot moved this from Ready for review to Done in MFIN Data Catalogue Dec 11, 2023
lkmorlan pushed a commit that referenced this issue Dec 12, 2023
This was linked to pull requests Dec 12, 2023
lkmorlan pushed a commit that referenced this issue Dec 14, 2023
lkmorlan pushed a commit that referenced this issue Dec 14, 2023
lkmorlan pushed a commit that referenced this issue Dec 14, 2023
lkmorlan pushed a commit that referenced this issue Dec 14, 2023
CraigClark pushed a commit that referenced this issue Dec 14, 2023
CraigClark pushed a commit that referenced this issue Dec 14, 2023
CraigClark pushed a commit that referenced this issue Dec 14, 2023
lkmorlan added a commit that referenced this issue Feb 15, 2024
Angle brackets were interpreted as the start of tags.

Fixes issue introduced in 9013993.
lkmorlan added a commit that referenced this issue Feb 15, 2024
Angle brackets were interpreted as the start of tags.

Fixes issue introduced in 9013993.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Alpha release as per Sprint With Us is anticipated Dec 31, 2023 Priority: high This issue has a high user or business impact and requires a hot fix Sprint 8 October 20 to November 9 Sprint 9 November 10 to November 30 Sprint 10 December 1 - December 31 task a task that a dev team member needs to address
Projects
5 participants