Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme build page #6

Closed
2 tasks done
CraigClark opened this issue May 10, 2023 · 1 comment
Closed
2 tasks done

Theme build page #6

CraigClark opened this issue May 10, 2023 · 1 comment
Assignees
@lkmorlan
Labels
alpha Alpha release as per Sprint With Us is anticipated Dec 31, 2023 enhancement New feature or request Sprint 10 December 1 - December 31
Milestone
Theming

Comments

@CraigClark
Copy link
Collaborator

CraigClark commented May 10, 2023 •
edited
Loading

OP timer

https://openplus.monday.com/boards/4092908516/pulses/4450507107

This feature support the following requirements

mvp build

Proposed solution

layout the build page so that:

  1. There is a section for each view mode
  2. Each of these sections shows the fields in that view mode. this should be the label and the value of the field. If there is no value, it should be label with optional or required beside it
  3. each section should have an edit link that looks like a button
  4. clicking edit takes me to the form mode for that section

This will be satisfied by:
@CraigClark CraigClark added the enhancement New feature or request label May 10, 2023
@lkmorlan lkmorlan moved this from Todo to In Progress in MFIN Data Catalogue May 18, 2023
lkmorlan added a commit that referenced this issue May 29, 2023
@lkmorlan
Issue #6: Add page_manager
ddbd7ce
lkmorlan added a commit that referenced this issue May 29, 2023
@lkmorlan
Issue #6: Disable layout builder for build page
2ad3f20
lkmorlan added a commit that referenced this issue May 29, 2023
@lkmorlan
Issue #6: Install page_manager_ui
5dc770c
lkmorlan added a commit that referenced this issue May 29, 2023
@lkmorlan
Issue #6: Re-save data_set_build_page display
c1bc08a
lkmorlan added a commit that referenced this issue May 29, 2023
@lkmorlan
Issue #6: Create build page to replace layout builder build page
eff5be9
lkmorlan added a commit that referenced this issue May 30, 2023
@lkmorlan
Issue #6: Update data_set_build_page display to match documentation
b8b7bc2
lkmorlan added a commit that referenced this issue May 31, 2023
@lkmorlan
Issue #6: Adjust formatting for build page
ac3b065
lkmorlan added a commit that referenced this issue May 31, 2023
@lkmorlan
Issue #6: Adjust formatting for build page
f6eaed6
lkmorlan added a commit that referenced this issue May 31, 2023
@lkmorlan
Issue #6: Set on/off labels for data_set boolean fields
466cc09
lkmorlan added a commit that referenced this issue May 31, 2023
@lkmorlan
Issue #6: Adjust config for data_set build page formatting
adb6e5a
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Do not link to referenced entities on build pages
e63dc13
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Trim long text on data_set build pages
608073c
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Use radio buttons for field_security_classification
3a2c384
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Display only column names on data_set build page
80f1ae0
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Add build page class to increase specificity of selectors
f94cdb2
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Set max-width for build page
3f349e5
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Set bottom margin for build page block-level fields
d0c5741
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Remove right-align and bolding for inline labels on build p…
e3ba523 
…ages
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Trim long text on data_set build pages
b9ac32d
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Use radio buttons for field_security_classification
03815c7
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Display only column names on data_set build page
ef95b43
lkmorlan added a commit that referenced this issue Jun 1, 2023
@lkmorlan
Issue #6: Show "required"/"optional" for empty fields
338ffde
lkmorlan added a commit that referenced this issue Jun 2, 2023
@lkmorlan
Issue #6: Configure access controls for build page
56f46c5 
This completes the work of eff5be9.
lkmorlan added a commit that referenced this issue Jun 2, 2023
@lkmorlan
Issue #6: Depend on page_manager
3f582f9 
Completes work of 5dc770c.
lkmorlan added a commit that referenced this issue Jun 5, 2023
@lkmorlan
Issue #6: Update data_set edit page to match documentation
e406c04
lkmorlan added a commit that referenced this issue Jun 6, 2023
@lkmorlan
Issue #6: Testing for data_set build page
c8d0a70
lkmorlan added a commit that referenced this issue Jun 6, 2023
@lkmorlan
Issue #6: Test columns on data_set build page
50bc5b5
lkmorlan added a commit that referenced this issue Jun 6, 2023
@lkmorlan
Issue #6: Test that field_security_classification widget is radio but…
cbba711 
…tons
lkmorlan added a commit that referenced this issue Jun 6, 2023
@lkmorlan
Issue #6: Test that long text gets trimmed
1e95c50
lkmorlan added a commit that referenced this issue Jun 6, 2023
@lkmorlan
Issue #6: Test that long text gets trimmed
a41118d
lkmorlan added a commit that referenced this issue Jun 6, 2023
@lkmorlan
Issue #6: Test that build page does not link to referenced entities
9ea706a
@lkmorlan lkmorlan moved this from In Progress to Ready for review in MFIN Data Catalogue Jun 6, 2023
lkmorlan added a commit that referenced this issue Aug 9, 2023
@lkmorlan
Issue #6: Restrict build pages to the data_set content type
9846588 
This completes the work of eff5be9.
lkmorlan added a commit that referenced this issue Aug 9, 2023
@lkmorlan
Issue #6: Restrict build pages to the data_set content type
5aa1d09 
This completes the work of eff5be9.
lkmorlan added a commit that referenced this issue Aug 10, 2023
@lkmorlan
Issue #6: Update to latest bcbb; fixes page_manager error from parent…
0023845 
… commit
@NicoledeGreef NicoledeGreef added this to the Theming milestone Oct 20, 2023
@NicoledeGreef NicoledeGreef added the alpha Alpha release as per Sprint With Us is anticipated Dec 31, 2023 label Nov 21, 2023
@CraigClark
Copy link
Collaborator Author

Tested and closing, there are a few build page tasks captured in #261

@github-project-automation github-project-automation bot moved this from Todo to Done in MFIN Data Catalogue Dec 7, 2023
@github-project-automation github-project-automation bot moved this from Ready for review to Done in MFIN Data Catalogue Dec 7, 2023
@CraigClark CraigClark added the Sprint 10 December 1 - December 31 label Dec 8, 2023
@NicoledeGreef NicoledeGreef mentioned this issue Jun 20, 2024
Closed
@NicoledeGreef NicoledeGreef mentioned this issue Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lkmorlan lkmorlan

Labels
alpha Alpha release as per Sprint With Us is anticipated Dec 31, 2023 enhancement New feature or request Sprint 10 December 1 - December 31
Projects
MFIN Data Catalogue
Status: Done
Milestone
Theming
Development

No branches or pull requests
3 participants
@CraigClark @lkmorlan @NicoledeGreef