Adjust report batch method names

bcgov · Feb 5, 2025 · 92ff5a9 · 92ff5a9
1 parent f6b893a
commit 92ff5a9
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/...end/apps/api/src/route-controllers/cas-invoice-batch/cas-invoice-batch.aest.controller.ts b/...end/apps/api/src/route-controllers/cas-invoice-batch/cas-invoice-batch.aest.controller.ts
@@ -77,13 +77,13 @@ export class CASInvoiceBatchAESTController extends BaseController {
    */
   @Get(":casInvoiceBatchId/report")
   @ApiNotFoundResponse({ description: "CAS invoice batch not found." })
-  async getInvoiceBatchesReport(
+  async getCASInvoiceBatchReport(
     @Param("casInvoiceBatchId", ParseIntPipe) casInvoiceBatchId: number,
     @Res() response: Response,
   ): Promise<void> {
     try {
       const invoiceReport =
-        await this.casInvoiceBatchReportService.getCASInvoiceBatchesReport(
+        await this.casInvoiceBatchReportService.getCASInvoiceBatchReport(
           casInvoiceBatchId,
         );
       const batchDate = getFileNameAsCurrentTimestamp(invoiceReport.batchDate);

diff --git a/...kages/backend/apps/api/src/services/cas-invoice-batch/cas-invoice-batch-report.service.ts b/...kages/backend/apps/api/src/services/cas-invoice-batch/cas-invoice-batch-report.service.ts
@@ -24,7 +24,7 @@ export class CASInvoiceBatchReportService {
    * @returns an object containing batch data and a CSV formatted string
    * data for the specified invoice batch.
    */
-  async getCASInvoiceBatchesReport(
+  async getCASInvoiceBatchReport(
     invoiceBatchId: number,
   ): Promise<CASInvoiceBatchReport> {
     const reportData = await this.getCASInvoiceBatchesReportData(

diff --git a/sources/packages/web/src/services/CASInvoiceBatchService.ts b/sources/packages/web/src/services/CASInvoiceBatchService.ts
@@ -32,10 +32,10 @@ export class CASInvoiceBatchService {
    * to support the batch approval and allow invoices to be sent to CAS.
    * @param casInvoiceBatchId batch ID to have the report generated for.
    */
-  async downloadCASInvoiceBatchesReport(
+  async downloadCASInvoiceBatchReport(
     casInvoiceBatchId: number,
   ): Promise<void> {
-    const file = await ApiClient.CASInvoiceBatchApi.getInvoiceBatchesReport(
+    const file = await ApiClient.CASInvoiceBatchApi.getCASInvoiceBatchReport(
       casInvoiceBatchId,
     );
     const { downloadFileAsBlob } = useFileUtils();

diff --git a/sources/packages/web/src/services/http/CASInvoiceBatchApi.ts b/sources/packages/web/src/services/http/CASInvoiceBatchApi.ts
@@ -32,7 +32,7 @@ export class CASInvoiceBatchApi extends HttpBaseClient {
    * @param casInvoiceBatchId batch ID to have the report generated for.
    * @returns file contents.
    */
-  async getInvoiceBatchesReport(
+  async getCASInvoiceBatchReport(
     casInvoiceBatchId: number,
   ): Promise<AxiosResponse<unknown>> {
     return this.downloadFile(`cas-invoice-batch/${casInvoiceBatchId}/report`);

diff --git a/sources/packages/web/src/views/aest/CASInvoices.vue b/sources/packages/web/src/views/aest/CASInvoices.vue
@@ -208,7 +208,7 @@ export default defineComponent({
       try {
         batch.downloadInProgress = true;
         snackBar.success(`Batch ${batch.batchName} report generation started.`);
-        await CASInvoiceBatchService.shared.downloadCASInvoiceBatchesReport(
+        await CASInvoiceBatchService.shared.downloadCASInvoiceBatchReport(
           batch.id,
         );
       } catch (error: unknown) {