Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lawyer proof selecting incorrect credential #2345

Closed
3 of 5 tasks
bryce-mcmath opened this issue Jan 15, 2025 · 3 comments
Closed
3 of 5 tasks

Lawyer proof selecting incorrect credential #2345

bryce-mcmath opened this issue Jan 15, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bryce-mcmath
Copy link
Contributor

bryce-mcmath commented Jan 15, 2025

Description of problem

Lawyers using ACM with both an old and new credential are having their old credential selected by default for presentation.

Expected behavior

The most recent, non-revoked credential is selected by default.

Steps to reproduce

Screenshots and/or log output

Environment

  • Occurs on Android
  • Occurs on iOS

Build #: Release 1.0.21 and 1.0.22, possibly older releases as well

Android Device Model:
N/A

iOS Device Model:
N/A

Workaround

Users can change selected credential to the correct one

Severity

  • High
  • Medium
  • Low
@bryce-mcmath bryce-mcmath added the bug Something isn't working label Jan 15, 2025
@bryce-mcmath
Copy link
Contributor Author

After going through many tests to reproduce, the wallet appears to be consistently selecting the most recently received credential as the default (correct behavior). There weren't very many reports of this and the reports were a bit unreliable (no screenshots etc.). It is possible these users were using an older version of the app, from before we added the sort by timestamp functionality, or perhaps their member card credential is from so long ago that it has gone through one or more credential migrations and some variance between the migrated credential's format and the new credentials format is causing the change in order of selection. Closing for now, can reopen if it is reported again.

@knguyenBC
Copy link

After speaking with Emiliano, I believe this is not the correct description of the issue that the user was experiencing.

@bryce-mcmath
Copy link
Contributor Author

True. It's more a description of what Emiliano and I thought was a potential cause of the actual issue the user was experiencing.

eg. an outdated credential is by default selected for the proof request -> they then see this when they try to respond to the proof (actual issue):
Image

For this ticket, we've confirmed (for the most part) that this isn't the cause. It could be caused by something else, like a delayed revocation, but that should probably be a different ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants