Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proper direct domains to sauce tunnel in build pipeline smoke test #1646

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

nodlesh
Copy link
Contributor

@nodlesh nodlesh commented Dec 1, 2023

This PR updates the direct domains on the Sauce Tunnel. This needed to be changed a while ago and was in the test pipeline but the build pipeline was overlooked. This causes the iOS smoke test to fail on an iOS build.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Sheldon Regular <[email protected]>
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bryce-mcmath
Copy link
Contributor

@jleach any idea why the check-secrets and check-vars steps are failing on this change? I can't see how those steps would be affected by this one-liner

Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the secrets and vars steps are acting up, but LGTM

@nodlesh nodlesh merged commit 47ca9b1 into bcgov:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants