Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Task List for Report Sign-Off and Submit #493

Closed
shon-button opened this issue Jan 10, 2025 · 3 comments
Closed

Conditional Task List for Report Sign-Off and Submit #493

shon-button opened this issue Jan 10, 2025 · 3 comments
Assignees

Comments

@shon-button
Copy link

shon-button commented Jan 10, 2025

Description of the Tech Debt

The task list for the "Sign-off & submit" section of the reporting workflow needs to conditionally display specific pages based on a verification requirement. This ensures that the task list reflects the correct steps required for submission.

Condition: needsVerification using the utility function getReportNeedsVerification(versionId).

If needsVerification is true, include the following pages from the task list:
"Verification"

If needsVerification is false, exclude the following pages from the task list:
"Verification"

@shon-button
Copy link
Author

PR Test Steps
Replace http://localhost:3000/ with https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/

@fviduya
Copy link

fviduya commented Jan 15, 2025

I have tested this in the DEV environment, here's the test document for reference.

I have verified that Verification page is displayed on the task list under Sign-off & Submit only when:

  • Registration Purpose = OBPS Regulated Operation, New Entrant, Opted-In, Reporting Operation (Total attributable emissions >= 25,000 tc02e)

I was not able to test the condition where Registration Purpose = Reporting Operation and total Emission Summary >= 25,000 tc02e due to issue with getting into Emission Summary page

I also tested some scenarios where Verification task list should not be visible:
Registration Purpose = Potential Reporting Operation - RESULT: Verification not showing on the task list, however, if you click Back button twice it will show the page itself, breadcrumbs also show Verification. Please check page 7 of the attached document.
^ Same as above for Registration Purpose = Reporting Operation < 25,000 tc02e

For the issue where verification page still displays after clicking Back Button twice, should that be addressed under #405? Or a different ticket?
cc: @vesselak / @patriciarussellCAS

@patriciarussellCAS
Copy link

patriciarussellCAS commented Jan 17, 2025

Thanks for testing this @fviduya - I will create a follow-up ticket (#505 ) for the issue you're experiencing and approve this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants