SFO Final Report Review Page - conditional "Continue" redirect

[shon-button]

Description of the Tech Debt

Apply the conditional routing from the final review page based on report needs verification:

Display verification page:

• If the registration purpose is OBPS Regulated Operation, Opt-in or New Entrants
• If the registration purpose is Reporting Operation AND their total emissions attributable for reporting threshold (from Emissions summary page) is = or > than 25,000 TCo2e, then they must fill out the verification page.
• Else display Attachments

Acceptance Criteria for Verification Page Requirement

1. Verification Page Trigger for Specific Registration Purposes

   • Given that I am a user and my registration purpose is one of the following:
     • OBPS Regulated Operation
     • Opt-in
     • New Entrants
   • When I have clicked the "Continue" button on the Final Review page,
   • Then I am redirected to the Verification form page.

2. Verification Page Trigger for Reporting Operation with High Emissions

   • Given that I am a user and my registration purpose is Reporting Operation, and my total attributable emissions (as displayed on the Emissions Summary page) are greater than or equal to 25,000 TCo₂e,
   • When I have clicked the "Continue" button on the Final Review page,
   • Then I am redirected to the Verification form page.

3. Bypass Verification for Reporting Operation with Low Emissions

   • Given that I am a user and my registration purpose is Reporting Operation, and my total attributable emissions are less than 25,000 TCo₂e,
   • When I have clicked the "Continue" button on the Final Review page,
   • Then I am not redirected to the Verification form page.

4. Bypass Verification for Other Registration Purposes

   • Given that I am a user and my registration purpose is not one of the following:
     • OBPS Regulated Operation
     • Opt-in
     • New Entrants
   • When I have clicked the "Continue" button on the Final Review page,
   • Then I am not redirected to the Verification form page.

Development Checklist:

• In file bciers/apps/reporting/src/app/components/finalReview/FinalReviewPage.tsx:

  • Create var needsVerification based on bciers/apps/reporting/src/app/utils/getReportNeedsVerification.ts

  • Pass const needsVerification to bciers/apps/reporting/src/app/components/finalReview/FinalReviewForm.tsx

  • In file bciers/apps/reporting/src/app/components/finalReview/FinalReviewForm.tsx:

    • Update const continueUrl to reflect routing based on const needsVerification

  • Update vitests

[fviduya]

I have tested this in the DEV environment, here is the test document for reference:

I can verify that:

• Report does not need verification based on registration purpose
• Report needs verification based on registration purpose
• Report does not need verification when registration purpose = Reporting Operations with low emissions
• Report needs verification when registration purpose = Reporting Operations with high emissions

The last two boxes are not ticked because I am getting a different error when I try to test where registration purpose = Reporting Operation. The error is documented and is on pages 8 and 9 of the document. It does not allow me to see the Final Review page itself, but when I change the URL to attachments, I see in the task list that it hides the Verification when it's not needed, but I am unable to actually navigate to the Final Review page.

Additional note:

• In page 3 of the document, there's an issue when clicking Continue from Final Review page when verification is not needed based on registration purpose. Found that the button itself navigates to 'attachment' instead of 'attachments'. The workaround is to click Attachments from the task list to get there.

cc: @patriciarussellCAS / @vesselak - moving this to Pending PO review for review of my test and notes. Thank you!

[patriciarussellCAS]

Thanks @fviduya and @shon-button
Question: Is this bug related to ticket #526 at all? edited to add that 526 has been added to #505

[fviduya]

Hi @patriciarussellCAS, I don't think it's related. The issue in #526 is about not being able to get to Sign-off page because of navigation issues. But, the two others that I wasn't able to check above doesn't actually allow me to see Final Review page. Also, since #505 consists of the issues in the navigation, maybe we can add my additional note above on that ticket?

[patriciarussellCAS]

Thanks @fviduya that makes sense. I feel like it will be hard to test the Reporting Operation conditions until we have that workflow properly built anyway. So I think we need to move those conditions out of this ticket for now. Would you mind adding these to 505? I would also flag this in #209

[fviduya]

Sure! I have updated 505 to include the issues found here.

[patriciarussellCAS]

I can confirm that AC 1 works as expected.
As noted as cannot test AC 2 or 3 yet. These should be addressed in ticket #505