Show correct application type on MBR

[ketaki-deodhar]

Creating this as a placeholder for work to be done based on the investigation in ticket #19118.

This might need fix in Legal-api, Auth-api and/or Auth-web. Discussion includes Travis, Argus, Kevin, Severin, Olga and David M

Please create ticket for each component as needed and add notes about TODO after the team discussion

Solution after the discussion:
Fix in Legal-api (/search endpoint):

Ref: https://github.com/bcgov/lear/blob/3b946ee011427976475b3ac0aa431cf85813e63d/legal-api/src/legal_api/resources/v2/business/business.py#L169

    bus_results = [x.json(slim=True) for x in bus_query.all()]
    draft_results = [
        {
            'identifier': x.temp_reg,
            'legalType': x.json_legal_type,
            **({'nrNumber': x.json_nr} if x.json_nr else {}),
            **({'legalName': x.filing_json.get('filing', {}).get(x.filing_type).get('nameRequest',{}).get('legalName')} if x.filing_type == 'amalgamationApplication' else {})
        } for x in draft_query.all()]

Fix in Auth-api and Auth-web:
wire up the Legal-api fix on Auth side.
Ref: https://github.com/kzdev420/sbc-auth/blob/fa2c5fd06ec5cf30ffb633a558ab0b281d4624b9/auth-api/src/auth_api/services/affiliation.py#L431

[severinbeauvais]

MS Teams discussion: https://teams.microsoft.com/l/message/19:[email protected]/1706055418079?context=%7B%22contextType%22%3A%22chat%22%7D

[severinbeauvais]

Hey team! Please add your planning poker estimate with Zenhub @severinbeauvais @ketaki-deodhar @PaulGarewal @jamespaologarcia @vysakh-menon-aot @yuisotozaki

[ketaki-deodhar]

Solution after the discussion:
Fix in Legal-api (/search endpoint):

Ref: https://github.com/bcgov/lear/blob/3b946ee011427976475b3ac0aa431cf85813e63d/legal-api/src/legal_api/resources/v2/business/business.py#L169

    bus_results = [x.json(slim=True) for x in bus_query.all()]
    draft_results = [
        {
            'identifier': x.temp_reg,
            'legalType': x.json_legal_type,
            **({'nrNumber': x.json_nr} if x.json_nr else {}),
            **({'legalName': x.filing_json.get('filing', {}).get(x.filing_type).get('nameRequest',{}).get('legalName')} if x.filing_type == 'amalgamationApplication' else {})
        } for x in draft_query.all()]

Fix in Auth-api and Auth-web:
wire up the Legal-api fix on Auth side.
Ref: https://github.com/kzdev420/sbc-auth/blob/fa2c5fd06ec5cf30ffb633a558ab0b281d4624b9/auth-api/src/auth_api/services/affiliation.py#L431

[PaulGarewal]

UPDATE: Worked with Travis to make these fixes in Lear. Can move to QA if bcgov/lear#2437 is merged.

[seeker25]

Should be good, in the future it would be nice to get most of our data from LEAR (related to PR above), instead of computing it in AUTH