Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All remaining layer functions prod worthy for v2 #3028

Closed
35 of 43 tasks
micheal-w-wells opened this issue Dec 29, 2023 · 0 comments · Fixed by #3052
Closed
35 of 43 tasks

All remaining layer functions prod worthy for v2 #3028

micheal-w-wells opened this issue Dec 29, 2023 · 0 comments · Fixed by #3052
Assignees

Comments

@micheal-w-wells
Copy link
Collaborator

micheal-w-wells commented Dec 29, 2023

Some of this might just be QA but some needs tuning for sure:

  • All Recordset functions working as expected.
  • Whats here working perfectly. Issue 3028 - 1 #3029
  • No quirky behaviours
    • Routing behaviour / navback a bit weird/clunky
      • Added back button
      • Fixed jumbled state a person can get in to toggling the button a few times or naving away
    • The box dissapearing is weird
    • The pins not highlighting
  • Loads data when it should
    • Activities
    • IAPP
  • Re-QA Whats here after holidays: More map action bulletproofing for #3028 #3032
    • Waits until Activities & IAPP Geojson + recordsets are loaded
      • Checks for Activities GeoJSON get
      • Checks for IAPP GeoJSON get
      • Checks for ANY recordset toggled on fetching
        - [ ] Spinners when it should I was unable to do this - the cpu is just pinned while its filtering so by the time it wants to draw spinner its done. Some people might see it. It's a brief hang.
  • Whats here interaction with pannel toggle solid
  • Labels + toggle Remaining toggle stuff for #3028 #3044
    • Activities

    • IAPP:
      Options:

      • Like for Like - have a load extent button for canvas layers * Works but sucks/clunky
      • Incorporate into donuts, and don't render until zoomed way in * TBD if works with our volume
      • Auto reload based on extent - when zoomed way out only use donut * TBD if works with our volume #3028 IAPP Labels #3043 Remaining toggle stuff for #3028 #3044
      • Grind out the dynamic PMTile rendering code * Doesn't allow for additional filtering on mobile offline
    • ⚡ Maybe just use PMTILE layer?? Much faster, displays what isn't there although no quirky load label extent UX

  • Both IAPP and Activities all release ready
    • Passed my testing as prod worthy - put feedback / new issues in another ticket (easier for me to manage issues from git).
      Shape dicts pushed up to s3 + only one copy anywhere in state is now Cron job to update GeoJSON on s3 #3031
@micheal-w-wells micheal-w-wells self-assigned this Dec 29, 2023
micheal-w-wells added a commit that referenced this issue Jan 3, 2024
Loads of state cleanup related to recordset functions & #3028
@micheal-w-wells micheal-w-wells mentioned this issue Jan 3, 2024
23 tasks
micheal-w-wells added a commit that referenced this issue Jan 3, 2024
micheal-w-wells added a commit that referenced this issue Jan 5, 2024
micheal-w-wells added a commit that referenced this issue Jan 6, 2024
Activity Spatial Filter query optimization for #3028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant