Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS - BUG - Fuel type and Determining carbon intensity #1696

Closed
airinggov opened this issue Jan 14, 2025 · 1 comment
Closed

LCFS - BUG - Fuel type and Determining carbon intensity #1696

airinggov opened this issue Jan 14, 2025 · 1 comment
Assignees
Labels
bug Something isn't working Compliance Reporting High High priority ticket but not critical at this time Tested :) Testing passed

Comments

@airinggov
Copy link
Collaborator

airinggov commented Jan 14, 2025

Describe the Bug:
When a schedule row is complete and saved, and the user changes the Fuel type, the Determining carbon intensity select field does not update to reflect the valid options for the new Fuel type. This allows users to save an invalid combination of Fuel type and Determining carbon intensity unless the field is manually clicked and updated.

This is an issue in:

  • Fuel supply
  • Fuels for other use

Ensure validation re-runs if a field is updated on a previously validated/saved row.

Expected Behaviour:
When the Fuel type is updated, the Determining carbon intensity select field should:

  • Automatically update to the correct value if only one valid option exists.
  • Prompt the user to make a new selection if multiple valid options are available.
  • Prevent saving until the Determining carbon intensity field is updated to a valid state.

Actual Behaviour:
The Determining carbon intensity select field does not update automatically when the Fuel type changes. Users can save the schedule row with an invalid combination of Fuel type and Determining carbon intensity.

Implications:

  • Inconsistent and incorrect data can be saved, leading to potential errors in processing or reporting.
  • Users are not alerted to the mismatch and may unknowingly save invalid combinations.

Steps To Reproduce:

  1. User/Role: Any user with access to edit schedule rows.
  2. Go to the schedule row editor and complete and save a row.
  3. Change the Fuel type in the schedule row.
  4. Observe that the Determining carbon intensity select field does not update unless manually clicked.
  5. Save the schedule row and note that the invalid combination is saved.

Additional Context:

  • The current behavior allows invalid data to persist, which could lead to downstream processing errors.
  • A fix should enforce field dependencies dynamically and prevent saving until all required fields are updated correctly.
@airinggov airinggov added bug Something isn't working Compliance Reporting High High priority ticket but not critical at this time labels Jan 14, 2025
@areyeslo areyeslo self-assigned this Jan 16, 2025
@airinggov
Copy link
Collaborator Author

@areyeslo that's working great now

@airinggov airinggov added the Tested :) Testing passed label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Compliance Reporting High High priority ticket but not critical at this time Tested :) Testing passed
Projects
None yet
Development

No branches or pull requests

2 participants