diff --git a/.github/workflows/analysis.yml b/.github/workflows/analysis.yml index 1f720fc98..c35476087 100644 --- a/.github/workflows/analysis.yml +++ b/.github/workflows/analysis.yml @@ -18,7 +18,7 @@ jobs: # https://github.com/github/codeql-action codeql: name: CodeQL - if: ${{ ! github.event.pull_request.draft }} + if: (! github.event.pull_request.draft) runs-on: ubuntu-22.04 timeout-minutes: 5 steps: @@ -38,7 +38,7 @@ jobs: # https://github.com/marketplace/actions/aqua-security-trivy trivy: name: Trivy Security Scan - if: ${{ ! github.event.pull_request.draft }} + if: (! github.event.pull_request.draft) runs-on: ubuntu-22.04 timeout-minutes: 1 steps: @@ -60,7 +60,7 @@ jobs: tests: name: Tests - if: ${{ ! github.event.pull_request.draft }} + if: (! github.event.pull_request.draft) runs-on: ubuntu-22.04 timeout-minutes: 5 services: diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 4d6c0f62b..2683308a7 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -149,12 +149,12 @@ jobs: echo "No triggers have fired, deployment skipped" - uses: redhat-actions/openshift-tools-installer@v1 - if: ${{ steps.triggers.outputs.triggered == 'true' }} + if: steps.triggers.outputs.triggered == 'true' with: oc: "4" - name: Deploy if Triggers Fired - if: ${{ steps.triggers.outputs.triggered == 'true' }} + if: steps.triggers.outputs.triggered == 'true' working-directory: ${{ inputs.directory }} shell: bash run: | diff --git a/.github/workflows/merge.yml b/.github/workflows/merge.yml index 01f8c0d09..ed85cc069 100644 --- a/.github/workflows/merge.yml +++ b/.github/workflows/merge.yml @@ -28,7 +28,7 @@ jobs: steps: # Get PR number for squash merges to main - name: Get PR Number From Event - if: ${{ github.event_name == 'push' }} + if: github.event_name == 'push' id: pr_no uses: bcgov/action-get-pr@v0.0.1 - name: PR Number diff --git a/.github/workflows/notifications.yml b/.github/workflows/notifications.yml index baf93aa6c..5310d8207 100644 --- a/.github/workflows/notifications.yml +++ b/.github/workflows/notifications.yml @@ -6,7 +6,7 @@ on: - completed jobs: notify-teams-pr: - if: ${{github.event.workflow_run.event == 'pull_request'}} + if: github.event.workflow_run.event == 'pull_request' runs-on: ubuntu-22.04 steps: - uses: simbo/msteams-message-card-action@latest @@ -26,7 +26,7 @@ jobs: image: ${{github.event.workflow_run.head_repository.owner.avatar_url}} text: PR Opened notify-teams-merged: - if: ${{github.event.workflow_run.event == 'push'}} + if: github.event.workflow_run.event == 'push' runs-on: ubuntu-22.04 steps: - name: PR Number diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 34c5c6100..168088be3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -21,7 +21,7 @@ jobs: steps: # Get PR number for squash merges to main - name: Get PR Number From Event - if: ${{ github.event_name == 'release' }} + if: github.event_name == 'release' id: pr_no uses: bcgov/action-get-pr@main - name: PR Number