From 76c79e8d94d1f2403ab6237fa9f853ae7b2c5b96 Mon Sep 17 00:00:00 2001 From: Dima K Date: Fri, 28 Jun 2024 07:38:02 -0700 Subject: [PATCH] Fix to show correct error when all home owners deleted --- ppr-ui/package-lock.json | 4 ++-- ppr-ui/package.json | 2 +- .../mhrRegistration/HomeOwners/HomeOwnersTable.vue | 8 ++++++++ ppr-ui/tests/unit/MhrTransferHomeOwners.spec.ts | 2 +- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ppr-ui/package-lock.json b/ppr-ui/package-lock.json index 663189c28..80f3c33f8 100644 --- a/ppr-ui/package-lock.json +++ b/ppr-ui/package-lock.json @@ -1,12 +1,12 @@ { "name": "ppr-ui", - "version": "3.2.28", + "version": "3.2.29", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "ppr-ui", - "version": "3.2.28", + "version": "3.2.29", "dependencies": { "@bcrs-shared-components/input-field-date-picker": "^1.0.0", "@lemoncode/fonk": "^1.5.1", diff --git a/ppr-ui/package.json b/ppr-ui/package.json index 7f703a2ff..de3a35c00 100644 --- a/ppr-ui/package.json +++ b/ppr-ui/package.json @@ -1,6 +1,6 @@ { "name": "ppr-ui", - "version": "3.2.28", + "version": "3.2.29", "private": true, "appName": "Assets UI", "sbcName": "SBC Common Components", diff --git a/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnersTable.vue b/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnersTable.vue index 7c1532a19..7d939cdd0 100644 --- a/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnersTable.vue +++ b/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnersTable.vue @@ -970,6 +970,14 @@ export default defineComponent({ item.groupId ) + const group: MhrRegistrationHomeOwnerGroupIF = getGroupById(item.groupId) + const isEmptyGroup = group.owners.every(owner => owner.action === ActionTypes.REMOVED) + + // mark empty groups as removed to show the 'No owners added yet' error + if (isEmptyGroup) { + group.action = ActionTypes.REMOVED + } + // When base ownership is SO/JT and all current owners have been removed: Move them to a previous owners group. if (groupHasRemovedAllCurrentOwners(getGroupById(item.groupId)) && showGroups.value) { moveCurrentOwnersToPreviousOwners(getGroupById(item.groupId)) diff --git a/ppr-ui/tests/unit/MhrTransferHomeOwners.spec.ts b/ppr-ui/tests/unit/MhrTransferHomeOwners.spec.ts index 1c534fc68..24c493ed3 100644 --- a/ppr-ui/tests/unit/MhrTransferHomeOwners.spec.ts +++ b/ppr-ui/tests/unit/MhrTransferHomeOwners.spec.ts @@ -418,7 +418,7 @@ describe('Home Owners', () => { expect(allDeletedBadges.length).toBe(1) expect(homeOwners.find(getTestId('invalid-group-msg')).exists()).toBeFalsy() - expect(homeOwners.find(getTestId('no-data-msg')).exists()).toBeFalsy() + expect(homeOwners.find(getTestId('no-data-msg')).exists()).toBeTruthy() const deletedOwner: MhrRegistrationHomeOwnerIF = homeOwners.vm.getMhrTransferHomeOwnerGroups[0].owners[0]