From 31c0a18c701aea330c51ae125cf92b796860b209 Mon Sep 17 00:00:00 2001
From: flutistar <brandonagalli@gmail.com>
Date: Thu, 5 Sep 2024 14:29:39 -0700
Subject: [PATCH 1/5] added hidden elements for ARIA

---
 ppr-ui/package-lock.json                      |  4 +-
 ppr-ui/package.json                           |  2 +-
 .../src/components/tables/SearchHistory.vue   | 44 ++++++++++++++-----
 3 files changed, 35 insertions(+), 15 deletions(-)

diff --git a/ppr-ui/package-lock.json b/ppr-ui/package-lock.json
index 17abbc5f7..61b968d72 100644
--- a/ppr-ui/package-lock.json
+++ b/ppr-ui/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "ppr-ui",
-  "version": "3.2.52",
+  "version": "3.2.53",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "ppr-ui",
-      "version": "3.2.52",
+      "version": "3.2.53",
       "dependencies": {
         "@bcrs-shared-components/input-field-date-picker": "^1.0.0",
         "@lemoncode/fonk": "^1.5.1",
diff --git a/ppr-ui/package.json b/ppr-ui/package.json
index cad1dc2f2..c13d4988b 100644
--- a/ppr-ui/package.json
+++ b/ppr-ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ppr-ui",
-  "version": "3.2.52",
+  "version": "3.2.53",
   "private": true,
   "appName": "Assets UI",
   "sbcName": "SBC Common Components",
diff --git a/ppr-ui/src/components/tables/SearchHistory.vue b/ppr-ui/src/components/tables/SearchHistory.vue
index d1740fbb4..85a11ed2a 100644
--- a/ppr-ui/src/components/tables/SearchHistory.vue
+++ b/ppr-ui/src/components/tables/SearchHistory.vue
@@ -13,6 +13,7 @@
           id="search-history-table"
           height="20rem"
           fixedHeader
+          role="table"
         >
           <template #default>
             <thead>
@@ -47,7 +48,7 @@
                         class="pr-2 mt-n1"
                         color="#212529"
                         aria-hidden="false"
-                        :aria-label="isPprSearch(item) ? 'PPR Search' : 'MHR Search'"
+                        :aria-label="headers[0].text + ',' + (isPprSearch(item) ? 'PPR Search' : 'MHR Search')"
                         role="img"
                       >
                         {{ isPprSearch(item) ? 'mdi-account-details' : 'mdi-home' }}
@@ -58,29 +59,38 @@
                     </v-col>
                   </v-row>
                 </td>
-                <td v-if="isPprSearch(item)">
-                  {{ displayType(item.searchQuery.type) }}
-                </td>
-                <td v-else>
-                  {{ displayMhrType(item.searchQuery.type) }}
+                <td>
+                  <span class="aria-label-only"
+                    aria-hidden="false"
+                  >{{ headers[1].text }}</span>
+                  {{ isPprSearch(item) ? displayType(item.searchQuery.type) : displayMhrType(item.searchQuery.type) }}
                 </td>
                 <td>
+                  <span class="aria-label-only"
+                    aria-hidden="false"
+                  >{{ headers[2].text }}</span>
                   <span v-if="isPprSearch(item)">Personal Property</span>
                   <span v-else>Manufactured Homes</span>
                 </td>
                 <td>
+                  <span class="aria-label-only"
+                    aria-hidden="false"
+                  >{{ headers[3].text }}</span>
                   <span v-if="!item.inProgress || isSearchOwner(item)">
                     {{ displayDate(item.searchDateTime) }}
                   </span>
                   <span v-else>Pending</span>
                 </td>
-                <td v-if="isStaff">
-                  {{ item.username }}
-                </td>
-                <td v-else>
-                  {{ item.searchQuery.clientReferenceId || '-' }}
+                <td>
+                  <span class="aria-label-only"
+                    aria-hidden="false"
+                  >{{ headers[4].text }}</span>
+                  {{ isStaff ? item.username : item.searchQuery.clientReferenceId || '-' }}
                 </td>
                 <td>
+                  <span class="aria-label-only"
+                    aria-hidden="false"
+                  >{{ headers[5].text }}</span>
                   <span v-if="!item.inProgress || isSearchOwner(item)">
                     {{ item.totalResultsSize }}
                   </span>
@@ -91,6 +101,9 @@
                   >-</span>
                 </td>
                 <td>
+                  <span class="aria-label-only"
+                    aria-hidden="false"
+                  >{{ headers[6].text }}</span>
                   <span v-if="(!item.inProgress || isSearchOwner(item)) && item.exactResultsSize >= 0">
                     {{ item.exactResultsSize }}
                   </span>
@@ -101,6 +114,10 @@
                   >-</span>
                 </td>
                 <td>
+                  <span class="aria-label-only"
+                    aria-hidden="false"
+                  >{{ headers[7].text }}</span>
+                  <span class="aria-label-only">{{ headers[3].text }}</span>
                   <span v-if="!item.inProgress || isSearchOwner(item)">
                     {{ item.selectedResultsSize }}
                   </span>
@@ -119,7 +136,7 @@
                     variant="plain"
                     :ripple="false"
                     :loading="item.loadingPDF"
-                    aria-label="Download PDF"
+                    aria-label="Download report, Download PDF"
                     @click="downloadPDF(item)"
                   >
                     <img src="@/assets/svgs/pdf-icon-blue.svg">
@@ -541,4 +558,7 @@ export default defineComponent({
 .dontRead {
   speak: none!important;
 }
+.aria-label-only {
+  display: none
+}
 </style>

From b4985eb9f09ca3837de080d3540f315e52169969 Mon Sep 17 00:00:00 2001
From: flutistar <brandonagalli@gmail.com>
Date: Fri, 6 Sep 2024 09:20:36 -0700
Subject: [PATCH 2/5] addressed code styling issue

---
 .../src/components/tables/SearchHistory.vue   | 57 +++++++++++++------
 1 file changed, 41 insertions(+), 16 deletions(-)

diff --git a/ppr-ui/src/components/tables/SearchHistory.vue b/ppr-ui/src/components/tables/SearchHistory.vue
index 85a11ed2a..b3e0f1764 100644
--- a/ppr-ui/src/components/tables/SearchHistory.vue
+++ b/ppr-ui/src/components/tables/SearchHistory.vue
@@ -60,37 +60,52 @@
                   </v-row>
                 </td>
                 <td>
-                  <span class="aria-label-only"
+                  <span
+                    class="aria-label-only"
                     aria-hidden="false"
-                  >{{ headers[1].text }}</span>
+                  >
+                    {{ headers[1].text }}
+                  </span>
                   {{ isPprSearch(item) ? displayType(item.searchQuery.type) : displayMhrType(item.searchQuery.type) }}
                 </td>
                 <td>
-                  <span class="aria-label-only"
+                  <span
+                    class="aria-label-only"
                     aria-hidden="false"
-                  >{{ headers[2].text }}</span>
+                  >
+                    {{ headers[2].text }}
+                  </span>
                   <span v-if="isPprSearch(item)">Personal Property</span>
                   <span v-else>Manufactured Homes</span>
                 </td>
                 <td>
-                  <span class="aria-label-only"
+                  <span
+                    class="aria-label-only"
                     aria-hidden="false"
-                  >{{ headers[3].text }}</span>
+                  >
+                    {{ headers[3].text }}
+                  </span>
                   <span v-if="!item.inProgress || isSearchOwner(item)">
                     {{ displayDate(item.searchDateTime) }}
                   </span>
                   <span v-else>Pending</span>
                 </td>
                 <td>
-                  <span class="aria-label-only"
+                  <span
+                    class="aria-label-only"
                     aria-hidden="false"
-                  >{{ headers[4].text }}</span>
+                  >
+                    {{ headers[4].text }}
+                  </span>
                   {{ isStaff ? item.username : item.searchQuery.clientReferenceId || '-' }}
                 </td>
                 <td>
-                  <span class="aria-label-only"
+                  <span
+                    class="aria-label-only"
                     aria-hidden="false"
-                  >{{ headers[5].text }}</span>
+                  >
+                    {{ headers[5].text }}
+                  </span>
                   <span v-if="!item.inProgress || isSearchOwner(item)">
                     {{ item.totalResultsSize }}
                   </span>
@@ -101,9 +116,12 @@
                   >-</span>
                 </td>
                 <td>
-                  <span class="aria-label-only"
+                  <span
+                    class="aria-label-only"
                     aria-hidden="false"
-                  >{{ headers[6].text }}</span>
+                  >
+                    {{ headers[6].text }}
+                  </span>
                   <span v-if="(!item.inProgress || isSearchOwner(item)) && item.exactResultsSize >= 0">
                     {{ item.exactResultsSize }}
                   </span>
@@ -114,12 +132,19 @@
                   >-</span>
                 </td>
                 <td>
-                  <span class="aria-label-only"
+                  <span
+                    class="aria-label-only"
+                    aria-hidden="false"
+                  >
+                    {{ headers[7].text }}
+                  </span>
+                  <span
+                    class="aria-label-only"
                     aria-hidden="false"
-                  >{{ headers[7].text }}</span>
-                  <span class="aria-label-only">{{ headers[3].text }}</span>
+                  >{{ headers[3].text }}</span>
                   <span v-if="!item.inProgress || isSearchOwner(item)">
-                    {{ item.selectedResultsSize }}
+                   
+                     {{ item.selectedResultsSize }}
                   </span>
                   <span
                     v-else

From 54d7bb2f3329d7576631f88fdefd0f37034589ee Mon Sep 17 00:00:00 2001
From: flutistar <brandonagalli@gmail.com>
Date: Fri, 6 Sep 2024 09:22:50 -0700
Subject: [PATCH 3/5] addressed code styling issue

---
 ppr-ui/src/components/tables/SearchHistory.vue | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/ppr-ui/src/components/tables/SearchHistory.vue b/ppr-ui/src/components/tables/SearchHistory.vue
index b3e0f1764..933b170d6 100644
--- a/ppr-ui/src/components/tables/SearchHistory.vue
+++ b/ppr-ui/src/components/tables/SearchHistory.vue
@@ -138,10 +138,6 @@
                   >
                     {{ headers[7].text }}
                   </span>
-                  <span
-                    class="aria-label-only"
-                    aria-hidden="false"
-                  >{{ headers[3].text }}</span>
                   <span v-if="!item.inProgress || isSearchOwner(item)">
                    
                      {{ item.selectedResultsSize }}

From 0d22f92ad88a0358220a2c427a3959e298e65657 Mon Sep 17 00:00:00 2001
From: flutistar <brandonagalli@gmail.com>
Date: Fri, 6 Sep 2024 09:23:52 -0700
Subject: [PATCH 4/5] addressed code styling issue

---
 ppr-ui/src/components/tables/SearchHistory.vue | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ppr-ui/src/components/tables/SearchHistory.vue b/ppr-ui/src/components/tables/SearchHistory.vue
index 933b170d6..87772b6b1 100644
--- a/ppr-ui/src/components/tables/SearchHistory.vue
+++ b/ppr-ui/src/components/tables/SearchHistory.vue
@@ -139,7 +139,6 @@
                     {{ headers[7].text }}
                   </span>
                   <span v-if="!item.inProgress || isSearchOwner(item)">
-                   
                      {{ item.selectedResultsSize }}
                   </span>
                   <span

From 0d075fde08a9735e5ffa9b89e1e4b0fe47d8f46b Mon Sep 17 00:00:00 2001
From: flutistar <brandonagalli@gmail.com>
Date: Fri, 6 Sep 2024 11:21:46 -0700
Subject: [PATCH 5/5] fixed unit test error

---
 ppr-ui/src/components/tables/SearchHistory.vue | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ppr-ui/src/components/tables/SearchHistory.vue b/ppr-ui/src/components/tables/SearchHistory.vue
index 87772b6b1..d3468c4b6 100644
--- a/ppr-ui/src/components/tables/SearchHistory.vue
+++ b/ppr-ui/src/components/tables/SearchHistory.vue
@@ -13,7 +13,6 @@
           id="search-history-table"
           height="20rem"
           fixedHeader
-          role="table"
         >
           <template #default>
             <thead>