From 5e329e669e69732c91447de881b49cd4237a5c27 Mon Sep 17 00:00:00 2001 From: Travis Semple Date: Thu, 25 Jan 2024 13:27:36 -0800 Subject: [PATCH] re-do feature flag --- auth-api/src/auth_api/services/affiliation.py | 2 +- auth-web/src/stores/business.ts | 3 +++ auth-web/src/util/constants.ts | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/auth-api/src/auth_api/services/affiliation.py b/auth-api/src/auth_api/services/affiliation.py index a7f019c09e..cb6c611a8c 100644 --- a/auth-api/src/auth_api/services/affiliation.py +++ b/auth-api/src/auth_api/services/affiliation.py @@ -400,7 +400,7 @@ def _affiliation_details_url(affiliation: AffiliationModel) -> str: if affiliation.entity.corp_type_code == CorpType.NR.value: return current_app.config.get('NAMEX_AFFILIATION_DETAILS_URL') # Temporary until legal names is implemented. - if flags.is_on('USE_ALTERNATIVE_NAMES_MBR', default=False): + if flags.is_on('enable-alternate-names-mbr', default=False): return current_app.config.get('LEAR_ALTERNATE_AFFILIATION_DETAILS_URL') return current_app.config.get('LEAR_AFFILIATION_DETAILS_URL') diff --git a/auth-web/src/stores/business.ts b/auth-web/src/stores/business.ts index 18df31f130..1201bdaef9 100644 --- a/auth-web/src/stores/business.ts +++ b/auth-web/src/stores/business.ts @@ -49,6 +49,9 @@ export const useBusinessStore = defineStore('business', () => { }) function determineDisplayName (resp: AffiliationResponse): string { + if (!LaunchDarklyService.getFlag(LDFlags.AlternateNamesMbr, false)) { + return resp.legalName + } if ([CorpTypes.SOLE_PROP, CorpTypes.PARTNERSHIP].includes(resp.legalType)) { // Intentionally show blank, if the alternate name is not found. This is to avoid showing the legal name. return resp.alternateNames?.find(alt => alt.identifier === resp.identifier)?.operatingName diff --git a/auth-web/src/util/constants.ts b/auth-web/src/util/constants.ts index 4e4f3a8f20..6ab4248210 100644 --- a/auth-web/src/util/constants.ts +++ b/auth-web/src/util/constants.ts @@ -407,6 +407,7 @@ export enum Permission { } export enum LDFlags { + AlternateNamesMbr = 'enable-alternate-names-mbr', AffiliationInvitationRequestAccess = 'enable-affiliation-invitation-request-access', BannerText = 'banner-text', BusSearchLink = 'bus-search-staff-link',